From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 34F673857033 for ; Mon, 12 Sep 2022 09:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34F673857033 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662974703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwmRhwUF7qEspWnXx8ppH7Amou1lKKujI6n4XdMlc7w=; b=P6bGVOEtL9ocyA2hjmU6iUJ+W6/C32ft1dbz23gqaprL5eIFzvTQ4PozK4Rs1qNsrB4Nb9 YS3WYGJ5n5JQq05DbMoW7xg4pMxpcQc+c9oKe/yX7Z5rYBSF5GRqeu/HetEBGVXozaIqV3 5e1tpl6eeCFmTeAsCloGFCtGmt3/aCU= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-349-vSO4qzf1PReEuT0g7t8kuw-1; Mon, 12 Sep 2022 05:25:02 -0400 X-MC-Unique: vSO4qzf1PReEuT0g7t8kuw-1 Received: by mail-qt1-f200.google.com with SMTP id b10-20020ac8540a000000b0035ba387b0d1so6007164qtq.15 for ; Mon, 12 Sep 2022 02:25:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=mwmRhwUF7qEspWnXx8ppH7Amou1lKKujI6n4XdMlc7w=; b=y6Ew+0gxg5UfW8Xs4PrRXQ2dmxr5/xZCstyXIBvD/RSzQTDh+Zxa0Psvqzrj3U+kk+ R1R8sSOsWI3FD46mV31R8VUt4PcR9rd29U2Kkz5DtuSWA+zHGbluy8ulEb8R/e5TXcv1 fWAbIJpwmUDqUOs9AZyuh/aQdvE+0mvwKO0uViU6Ngq4fRe2jJWxQv57yVz6EEMrO5u0 Vv3oHRyPQkj4im3g+am3bLz9fXGBs9T/kYKOZzsQLUVvB+r9irMDxF5wg1364yWcGIXo frF7jw6C3SzPPUvwD5gzpbe8MR0VCPRFb0dC35XYsRkObyT6ewiTZG9G3H6mRZm8iS5N tahg== X-Gm-Message-State: ACgBeo1f8IqG0Gcgyq7YIVxyG1+5KsbCt9qRLiP38R6M1Xc26Q9wvJU8 RopjRvixXU1g7icfeXDLBCPf2FmixZXe+6TVOp6z4XQtZOzSiAXvHqnMRLb19Jt9H78b1/Iu/tc aiijzWyULAF/eSTS3NqrfcP40Pw8Y7Fh5Hg== X-Received: by 2002:a05:620a:c9b:b0:6cb:cde2:27b5 with SMTP id q27-20020a05620a0c9b00b006cbcde227b5mr12997883qki.293.1662974701698; Mon, 12 Sep 2022 02:25:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR7HN3vKRHTjvlpNeBLisJIXuG8nFskgOHImDj6cYuBV+/BefoDQPO9tsNkrjGQms0veB5eHoPx37AVneOYpCZ8= X-Received: by 2002:a05:620a:c9b:b0:6cb:cde2:27b5 with SMTP id q27-20020a05620a0c9b00b006cbcde227b5mr12997879qki.293.1662974701523; Mon, 12 Sep 2022 02:25:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 12 Sep 2022 10:24:50 +0100 Message-ID: Subject: Re: Patch ping^3 ([PATCH] libstdc++: Outline the overlapping case of string _M_replace into a separate function [PR105329]) To: Jakub Jelinek Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 12 Sept 2022 at 10:16, Jakub Jelinek wrote: > > On Wed, Aug 31, 2022 at 11:38:58AM +0200, Jakub Jelinek via Gcc-patches wrote: > > On Wed, Aug 10, 2022 at 01:27:51PM +0200, Jakub Jelinek via Gcc-patches wrote: > > > On Wed, Jul 27, 2022 at 11:33:29AM +0200, Jakub Jelinek via Gcc-patches wrote: > > > > The following patch is partially a workaround for bogus warnings > > > > when the compiler isn't able to fold _M_disjunct call into constant > > > > false, but also an optimization attempt - assuming _M_disjunct (__s) > > > > is rare, the patch should shrink code size for the common case and > > > > use library or for non-standard instantiations an out of line > > > > function to handle the rare case. > > > > > > I'd like to ping this patch. > > > > I'd like to ping this patch again. > > https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598896.html > > Ping again. OK for trunk, sorry for the slow review.