From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0D76F3882005 for ; Thu, 18 May 2023 13:05:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D76F3882005 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684415140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lzQENKrRteOhZtzwk+7hFHpketSSz+hlFxwqVKeEPl0=; b=KwFIs5b9WW4L8POIMyCtyEZxCkoiVWslWmxKKbHH8KP8mM0+m2ffnq8rGuiFYloIoP36Dc 4tbOK41sYSGumT5+/cMaw6ag4A8Kmvf/xRpX+S+t/5d4Fb43oodCP2qXjrB1OJyAhtaGSy hdMSaNIU72jaAMLlqXsY1Q5NQp7BBl0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-nYJj-ox7ME2YKMfiQ80jAQ-1; Thu, 18 May 2023 09:05:39 -0400 X-MC-Unique: nYJj-ox7ME2YKMfiQ80jAQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ac7f9e64ecso10268531fa.3 for ; Thu, 18 May 2023 06:05:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684415138; x=1687007138; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lzQENKrRteOhZtzwk+7hFHpketSSz+hlFxwqVKeEPl0=; b=eW0PrrBL+dW/UXZW539I8y/la9KwV+oVRTusuTuPO5aGe4GmFtZNyFJkdLrlZpHyTC K2e1Wvo+j+9ZQj3e5TNARFrUK4Is6J8MvmqCMIu64VzCoA/Yl2QT5hxpwfjCOGndpxgZ YeV/fafFZNK8VdrOop2/+47LuReHXBwIhuPEnzAQhq5ksEWy0PcGxDtt1CnCfl3zpCMQ fSKPslRkIUaoonuRLvawfH9xz1mNv5jlC0+a782yvvnwQxtspQKOaMKiJ5Y43/B5MhDG kPv8VsoQ6zzNBK/K3fEOtjZnPM9ZY4TMsXIiELYnD2tY368/rpyNYZKp2RdOPELL1nmO lDIQ== X-Gm-Message-State: AC+VfDyR2O3FRBIZhrW3NKOFk3vhjZK33Atu1ytz50OcAoAfT/r0WLdQ DlgMVcSw7p2lRKJftTRfwYwalJFzy2sLirahnPofTNEKQv61u3LvNc99ktO4QLDbYxAAx5twAvS UurxWO9RgY9PVYhJoBnzYxiW1/SEtnsHlfscRNA8mfw5t X-Received: by 2002:a05:651c:14d:b0:2ad:ce08:7a2b with SMTP id c13-20020a05651c014d00b002adce087a2bmr7127783ljd.22.1684415137894; Thu, 18 May 2023 06:05:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Tu1ji/AUxDhjd3Mk60r36koqTCrSy0O1m/xu9bdLzWn3/EfwR/4LqB9bu1aXZxp3tOiut8SAUPYoKOUv3CMU= X-Received: by 2002:a05:651c:14d:b0:2ad:ce08:7a2b with SMTP id c13-20020a05651c014d00b002adce087a2bmr7127773ljd.22.1684415137496; Thu, 18 May 2023 06:05:37 -0700 (PDT) MIME-Version: 1.0 References: <20230518125647.2105203-1-jwakely@redhat.com> <20230518125647.2105203-3-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 18 May 2023 14:05:26 +0100 Message-ID: Subject: Re: [PATCH 2/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000eccfdf05fbf77560" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000eccfdf05fbf77560 Content-Type: text/plain; charset="UTF-8" On Thu, 18 May 2023 at 13:59, Jakub Jelinek wrote: > On Thu, May 18, 2023 at 01:56:46PM +0100, Jonathan Wakely via Gcc-patches > wrote: > > --- a/gcc/testsuite/gcc.test-framework/gen_directive_tests > > +++ b/gcc/testsuite/gcc.test-framework/gen_directive_tests > > @@ -322,8 +322,8 @@ two() { > > echo "${GOOD_PROG}" >> $FILE1 > > echo "${GOOD_PROG}" > $FILE2 > > > > - if [ "${FAIL_VERSION}" == "yes" ]; then > > - if [ "${EXP}" == "${EXP_PASS}" ]; then > > + if "yes" ]; then > > This line looks suspicious... > Yikes! I think instead of clicking on the first '=' character I must have selected the whole of `"${FAIL_VERSION}" =` and then deleted it all. v2 patch at https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618919.html > > + if [ "${EXP}" = "${EXP_PASS}" ]; then > > NAME=${KIND1}-${KIND2}-${EXP_FAIL} > > else > > NAME=${KIND1}-${KIND2}-${EXP_XFAIL} > > @@ -364,8 +364,8 @@ three() { > > echo "${GOOD_PROG}" >> $FILE1 > > echo "${GOOD_PROG}" > $FILE2 > > > > - if [ "${FAIL_VERSION}" == "${yes}" ]; then > > - if [ "${EXP}" == "${EXP_PASS}" ]; then > > + if [ "${FAIL_VERSION}" = "${yes}" ]; then > > + if [ "${EXP}" = "${EXP_PASS}" ]; then > > NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_FAIL} > > else > > NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_XFAIL} > > -- > > 2.40.1 > > Jakub > > --000000000000eccfdf05fbf77560--