From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4D9483858425 for ; Fri, 13 Jan 2023 17:38:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D9483858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673631514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BJ/fYkOUHFPhNP3M1vzjEKl10SlRV95zIm8kwiAOhYo=; b=WtVIj5Ws9JArGKIZww/fS9xaFdcq47Vxd0IYQCEwDcyLxUmI4hqSTnl2IfRNw/lWTslkJV HZ5cTsuPf5KbGNKoAOn4bxJSfnCGLNnrummdfM11EyS0NAFBAI98L9BjCDYSqEZwKy6gG5 Vmpxg/omovFZHzrEvb1SdYa9E6IcTlk= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-642-jRyWO7RUPxeCrxaGzhfGnw-1; Fri, 13 Jan 2023 12:38:32 -0500 X-MC-Unique: jRyWO7RUPxeCrxaGzhfGnw-1 Received: by mail-lj1-f200.google.com with SMTP id r20-20020a2e8e34000000b002838fc9f1feso4851593ljk.9 for ; Fri, 13 Jan 2023 09:38:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BJ/fYkOUHFPhNP3M1vzjEKl10SlRV95zIm8kwiAOhYo=; b=BDFAZXopCWq3Q8zsEkbI4qmwXM+p/XdhQ/HWytg4xBIG2RZ3/QsXPdmSI38WzNJhwO ZhXmNSWob78S7T8IZywpt60vXeWLdGFfPDT916ZQ7utjhdWEKmA4zR8HMGaqtqH+biQG 7Q90B7ygAyAy2Achc/4693F9qmRE1sG+/d9awRwd2P07fuhsIiqRU97xtHm7w2Va2Llq fFSFrOJSgvInZw1N7/zgt/OMc/as0F+jrBFbpLmzbGIhYmc3HcpYHw6CAWR88KNN2Xf7 d69YNl1VOBmKztTP7PNIkMnaQ9wUDn46XHMwf1BTd+RT7H6oXPFcVqcVdCMhVRQC5G8o 2vHA== X-Gm-Message-State: AFqh2ko0LvulvbDt7410E5jAWH4a5WtOeyMS9lL9fFk/j85pADXAR4ti bZC6FBF/JyZwzQntFCwg6JNLcMkU6gbix4wcAl4MjIeAOy+s+TBu13mxpSQD1IRLK+0DFP+/0E4 Xm6khlOrtQQSfe9zdBUK8NFBMOvQRxNTsxQ== X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3177007lfp.17.1673631511441; Fri, 13 Jan 2023 09:38:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXurkM9c7aLzI9pWYHQ9zpWn2o3PpcV/CoIPaG//SCz0LYGj1Fq7nIw2vhHR8IAD3fxKW0TttALtdmpoIXW0vyI= X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3177005lfp.17.1673631511246; Fri, 13 Jan 2023 09:38:31 -0800 (PST) MIME-Version: 1.0 References: <20230113001546.944147-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 13 Jan 2023 17:38:20 +0000 Message-ID: Subject: Re: [committed] libstdc++: Do not include in concurrency headers To: Rainer Orth Cc: Jonathan Wakely via Gcc-patches , libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 13 Jan 2023 at 16:39, Jonathan Wakely wrote: > > On Fri, 13 Jan 2023 at 15:08, Rainer Orth wrote: > > > > Hi Jonathan, > > > > > The , , and headers use > > > std::errc constants, but don't use std::system_error itself. They only > > > use the __throw_system_error(int) function, which is defined in > > > . > > > > > > By including the header for the errc constants instead of the whole of > > > we avoid depending on the whole std::string definition. > > > > it seems this patch broke many tests on Solaris, e.g. > > > > FAIL: 29_atomics/atomic/requirements/types_neg.cc (test for excess errors) > > Excess errors: > > /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/bits/std_mutex.h:157: error: 'EBUSY' was not declared in this scope > > > > Oops, testing this patch now. Pushed to trunk - thanks for the report!