From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5FE223858D39 for ; Wed, 17 May 2023 09:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FE223858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684314376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lk7ePTEAML2CM000BOg4Jqx1SS0MaaBpXc8XGpPXejQ=; b=Us5tKAmeYTTQsUL5w9bkMfTND7BY4/D9z3KDRRQfY5El0u0or9yYa34EFzzwjzkhR/DNtb yfW1/c028vfkjC6AHYz69YIkdXU/RrH68GfOU2HW3vhrhic+KZbk42lNlH3hVDCKINzztP Gf2X4Ip0Luh0GaK0pT3RIQe5XWhoTw0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-DC_no3-EPy60UWEJfwK1cg-1; Wed, 17 May 2023 05:06:12 -0400 X-MC-Unique: DC_no3-EPy60UWEJfwK1cg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ac7d0a822eso1837681fa.3 for ; Wed, 17 May 2023 02:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684314371; x=1686906371; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lk7ePTEAML2CM000BOg4Jqx1SS0MaaBpXc8XGpPXejQ=; b=MaGgO4ThWrDu8fiej0n7aLay5ELgY/+eLC6efsNRIHjPD/S7itOm8HCqXO1ksGDzp0 thUdS8tD3//zGrOlkemgSjIXTFRNrvlBwtu7xzrcVH0ukvs0bpI3vD5mPuwjeWp37Eim 6A0p8q6Od9y5x6uWQwExE3zdCBJF45ADne/eEXUaJ7oxVXvkBXsmGaW7jnJB8mHK49Av 1EslmEMBFSTftUHo3+xq7U8ANEH58hSbYFpM96wBosE9DtTZtktvfUctNv6uFRLCOCkA OcdtFmlQJlyAun3s0mOES3EK/rbTpfikTGUPB10mnxAnLCiIcUN9ebCLDpNWzBw/d/RD 4OVw== X-Gm-Message-State: AC+VfDwbTnrEHZzAGy9EYxqh/vwYJHYOqc8Bm7mforuAxen4er8Woy9w mwgLBZRDTq/pNJWJ1bgVvPetR4ai5+0P7fktttuslj0jtbrjQow8xEQIelF534aNWtwRNPzMov+ 8EXg5GWx9aTMw+IDgGTH1JMYIN8gXWjRR7w== X-Received: by 2002:a2e:9b97:0:b0:2ad:98a6:4af0 with SMTP id z23-20020a2e9b97000000b002ad98a64af0mr9226489lji.23.1684314370869; Wed, 17 May 2023 02:06:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5mnk0gRwdRQN1pM4+Qtm92sEWM8n3SREXUVf9HfpiATYR47s9S3J7R8gvUfLo0TnXYhSuTp0eD/5u5EOB+EY0= X-Received: by 2002:a2e:9b97:0:b0:2ad:98a6:4af0 with SMTP id z23-20020a2e9b97000000b002ad98a64af0mr9226475lji.23.1684314370465; Wed, 17 May 2023 02:06:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 17 May 2023 10:05:59 +0100 Message-ID: Subject: Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700] To: Nathaniel Shead Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000bdfced05fbdfffbc" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000bdfced05fbdfffbc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 17 May 2023 at 09:37, Nathaniel Shead wrote: > Now that GCC13.1 is released is it ok to merge? Thanks! > Yes, I've been testing this locally, but I think it needs more work (sorry!) Looking at it again, I'm not sure why I asked for the additional tests because if they fail, it's a problem in libc, and there's nothing we can actually do about it in libstdc++. We certainly do want std::expl(0.0L) to return the same thing as std::exp(0.0L), but if it doesn't, we'll just have a libstdc++ test failure caused by a bug in libc. But you wrote the test now, so let's keep it. If we get failures for the test it will allow us to inform the relevant libc maintainers that they have a bug. Also, since you're contributing this under the DCO terms the new test should not have the FSF copyright header, unless it's a derived work of an existing test with that header (and in that case it should retain the dates from the copied test). I don't actually bother putting the copyright and license header on new tests these days. There's nothing in that test that is novel or interesting, and I think it's arguably not useful or meaningful to consider it copyrighted. Finally, and most importantly, the new using-declarations in are not guarded by any autoconf macro. That will break targets without full C99 support, e.g. djgpp declares acosf but not acosl, so the new "using acosl;" would be a hard error as soon as is included (and might even prevent GCC building on that target). So I think we need a new autoconf check for the existence of those functions. I'm in the process of reworking the autoconf macros for (due to PR 109818), which is why I didn't address it for this patch yet. > > On Tue, Apr 18, 2023 at 6:48=E2=80=AFPM Jonathan Wakely > wrote: > > > > On Mon, 17 Apr 2023 at 09:11, Nathaniel Shead > wrote: > > > > > > Hi, just checking whether there were any issues with this patch? > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612386.html > > > > > > Otherwise I assume it won't be in GCC13. > > > > That's right, it's too large and invasive a change to get into GCC 13 > > when only submitted in February, sorry. I'll merge it to trunk once > > GCC 13.1 is released though. > > > > --000000000000bdfced05fbdfffbc--