From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C1BAF385B53C for ; Tue, 21 Mar 2023 17:12:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1BAF385B53C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679418773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cHm3/tKdPJVqHBbHBdLBrjdoutviAupyxTfbRyE9dUA=; b=CnU0UqKrmkljzRsTJpY7G25tFrqer7+ewE19iejp0jNMJpzYvXluXVJGzixXSEAiRVISj5 fDq1HuDMAME0P5GvOGQPtgh1NeB5Ea9wMVdhK0+2U2oqYK8BUPs4GpRbQW2Ydl6Vg6tnNF 4Tau3AC3L/u/5lFkoDYaLbswIlp/U8o= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-F6dlyNqMOk-4dmX4SFaXVw-1; Tue, 21 Mar 2023 13:12:49 -0400 X-MC-Unique: F6dlyNqMOk-4dmX4SFaXVw-1 Received: by mail-lj1-f198.google.com with SMTP id m5-20020a2ea585000000b00295ba03f905so4271922ljp.12 for ; Tue, 21 Mar 2023 10:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679418768; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cHm3/tKdPJVqHBbHBdLBrjdoutviAupyxTfbRyE9dUA=; b=JI8ObrSPjoZkVaFg9Qdop3/epABnBU8kEW6pFZwuFu8wXmtfNd1Vw2jecE7Z/SBrLD giLHXPvA+SZwZrxw/e1uJF6ad6vKdT/iQS+H82GIX171LD76IrzUvwNVZkXk8omSTj1b YhKsOROM+HlfNcgQYmlY8FvpvQae989IF+L9CpxeA+f4XarRNL8vLAONLYRsk+tXFce3 wdJF4wYBjoba0Lz+0/kJlHd7suSzBRMInCJ1HI7MKFOmtVqqMBsO6/55AyIhNHoHzVz4 xVGu43pvn+/7U7Q77z88d3iJLYhlC0fpK31W811hW28iUKXxgroBseyNFTt2zLZXV1Tl GhZw== X-Gm-Message-State: AO0yUKUHGAPtNI9AaqPFE2knO0csjn2zGNcbbckNhhXdcdX1QM1lIZ/L IouVb9VBKT/bIItdrcAfSGxD8V7x7N3EGAlY8Frg7nA4LaZMx7xXbQTKHSnR+iSTD2vpyCIApav TV4+5Pqz25kDy/0GFwVLWvW7/d5wCqVPUGA== X-Received: by 2002:ac2:46c5:0:b0:4e8:dcb2:b2ea with SMTP id p5-20020ac246c5000000b004e8dcb2b2eamr1019763lfo.8.1679418768149; Tue, 21 Mar 2023 10:12:48 -0700 (PDT) X-Google-Smtp-Source: AK7set9asefCeKm++HeVb7ohM/0Z20l4nRQ3Zt9XBBv283yILRauCEDxHdnNlZfQiPNyqAsfzvLKsX07GdTeVX5Ykxo= X-Received: by 2002:ac2:46c5:0:b0:4e8:dcb2:b2ea with SMTP id p5-20020ac246c5000000b004e8dcb2b2eamr1019757lfo.8.1679418768018; Tue, 21 Mar 2023 10:12:48 -0700 (PDT) MIME-Version: 1.0 References: <7568297.R56niFO833@minbar> In-Reply-To: <7568297.R56niFO833@minbar> From: Jonathan Wakely Date: Tue, 21 Mar 2023 17:12:37 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Skip integer division optimization for Clang To: Matthias Kretz Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000018e27305f76c2716" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000018e27305f76c2716 Content-Type: text/plain; charset="UTF-8" On Tue, 21 Mar 2023 at 17:06, Matthias Kretz via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > Tested on x86_64-pc-linux-gnu. > > --------- 8< ----------- > > Clang ICEs on _SimdImplX86::_S_divides. The function is only working > around a missed optimization and not necessary for correctness. > Therefore, don't use it for Clang. > > Signed-off-by: Matthias Kretz > > libstdc++-v3/ChangeLog: > > * include/experimental/bits/simd_detail.h: Don't define > _GLIBCXX_SIMD_WORKAROUND_PR90993 for Clang. > * include/experimental/bits/simd_x86.h (_S_divides): Remove > check for __clang__. OK --00000000000018e27305f76c2716--