From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7DE823856948 for ; Mon, 6 Nov 2023 23:29:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DE823856948 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7DE823856948 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699313356; cv=none; b=d1WgiX98Lj4J3dMbGYio8s4rIFkRQDDzKu3p3RdeWCtX7hZiE3VPr8SUnNAIP+qcbQ/DLin2v0+TPTEYjTmpmbGRD2RFhRcLkDegUcWyR60c1dzLc5nRrfu23E5esqajiRFiVWmydi1wQPbCek9fBKbXZNCGmA4akb1ek7xUYTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699313356; c=relaxed/simple; bh=jklRyOxHb1UtI+Y95DdhRWXHq6TUIRa77WV50BnNIZA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=qd1VPMN3O4coXfYPujNESDNY163lqd4C3d0noLi1Uy0PHyg6iaQV2+zJxAT3xRhauzMQpy0z7PjBosGkmXPdaLL+Auyi75bkNJ+3wellqLhnuZsQ3lkchLGg8sa2RISE9mX/XWcRQVMJsm+cqAHA9pWw8f8g5zQqeTRhIxTu6Cg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699313355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zroHCtNYkiL6kGTmu2/mITHW7wqH/Yz5WXMi4xNTKoU=; b=PQlMx49Wf3ntuPUon2BXfOesmXledp4nAUu6X34SW7wcZmDGMD6MEdNk05duBSfUlXaKgS UKUqGzuru3y5CnTdEQr2qb+a/EUFQufoGYXjIzex1t81/mBSTHxmeFfMsnVhIWxnHJ2qez pikHSvWdo6T4wB6RRlYOU8XVOoKhvEA= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-GIhyoRKfOV-FaKyx5TDsMg-1; Mon, 06 Nov 2023 18:29:02 -0500 X-MC-Unique: GIhyoRKfOV-FaKyx5TDsMg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5afc00161daso58534427b3.1 for ; Mon, 06 Nov 2023 15:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699313342; x=1699918142; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zroHCtNYkiL6kGTmu2/mITHW7wqH/Yz5WXMi4xNTKoU=; b=XjEacTnpodPMf8ptBvVzqiw8Afb2onEduQr+PRgRWF6CNu5wzh1NPFnqQB7dSGD1+v wm8X34qUOm3iSdx9tXdgTBSwXSQQ0/p1taxECLdflQjYP8n/MvCA0XbzSD2aWm/xIuvU m1MFHUSHBLFlNCCYn7+w+b2CXPLWK6B1TDhITvqa/64ADF9VOZ32x+olXQmCpjQ5snR+ a+udpWW1Q6icVmLfdLuH9BGNzS+YQmTVvykb6ChdDCCCEzwe62c357Bsz8wNIdbSGrDM BinFOxooEMg1J4U4NP94dQ3Dn5Efv92QyeUko+ls32xpKjyVl9cDiyCr7cIiBKFFd5Hi Bi7w== X-Gm-Message-State: AOJu0YxO/rQEbaWrdOBYiWp98iznt0IfFbPn3IXCVafkllOcScA8q8+e x0gl7bOHmfKhP/xK7THLhz1+tC6SnKub9PSHdY9ea942IAfwXH6+2A1YcH47qgW1+eUIre8hBuq FK15Abd0B1iZlQttV9H/4mte8ihzHtzFChA== X-Received: by 2002:a25:d816:0:b0:da0:5e86:32f8 with SMTP id p22-20020a25d816000000b00da05e8632f8mr24258850ybg.4.1699313342123; Mon, 06 Nov 2023 15:29:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxuBthYU2Gx8Fvu80NAP0kw/U4citC5NQIBn6MDGZ7RgamyegR3tzS8hWoBlaTbZjDlCDBtfY48Kc30goUWK0= X-Received: by 2002:a25:d816:0:b0:da0:5e86:32f8 with SMTP id p22-20020a25d816000000b00da05e8632f8mr24258845ybg.4.1699313341924; Mon, 06 Nov 2023 15:29:01 -0800 (PST) MIME-Version: 1.0 References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> In-Reply-To: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> From: Jonathan Wakely Date: Mon, 6 Nov 2023 23:28:51 +0000 Message-ID: Subject: Re: [PATCH][_Hashtable] Add missing destructor call To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 6 Nov 2023 at 21:39, Fran=C3=A7ois Dumont wr= ote: > > Noticed looking for other occasion to replace __try/__catch with RAII > helper. > > libstdc++: [_Hashtable] Add missing node destructor call > > libstdc++-v3/ChangeLog: > > * include/bits/hashtable_policy.h > (_Hashtable_alloc<>::_M_allocate_node): Add missing call to > node destructor > on construct exception. > > Tested under Linux x64, ok to commit ? OK. Is this missing on any branches too? I don't think it's actually a problem, since it's a trivial destructor anyw= ay. > > I hope gmail appli will appreciate .diff instead of .patch. .txt are not > in .gitignore so annoying to use for patches. > > Fran=C3=A7ois