From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5C78F3858434 for ; Mon, 7 Mar 2022 15:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C78F3858434 Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-QCie_FBgM92LX2wnLQVDRA-1; Mon, 07 Mar 2022 10:15:08 -0500 X-MC-Unique: QCie_FBgM92LX2wnLQVDRA-1 Received: by mail-yb1-f200.google.com with SMTP id a3-20020a5b0ac3000000b006288f395b25so13732706ybr.18 for ; Mon, 07 Mar 2022 07:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rWY2vIyDZeaxAORKqhC2jYhCfeioARn08UCc65Y6jII=; b=P4U1+N0pelRIOsLUC+o6m41GFkvSH1AVa6gRHtbObvGAV8NVAVy2lL0r+5lg1FmLEV 76HeqGCh5syfpf8dOAtkov9BU33EvPwb1WzxS/r0JLjbM7pBsMMMkg04g9nJkPm0Jeqk xKpNKu8GNYTeHE9Xmf1as1eXyj740T7q70dmls/EeU9k7Lk00DtLMJ+upLx6UdXYH+T/ ks01W3z8Rm2H+EFbISM1JfjitQ2zFGCFIXspfHrSaIYPy6KXyoxXKTUKdcTP3JHMo6cu AJhI5Ag0zMqG3n4jQlqX0AKKQ7D9trQIdR5DQcfEBc+szn3RAmjP2EEJOk8yRggMaGVQ /5Nw== X-Gm-Message-State: AOAM531fAzc/Vzy3ymraDzTNBc0jRDrsihzSPv73QOr0RRJNmUq+swXg e1Cuzr9rXqEAn9RrWaKfq5KY/3ABhlhqtUkNpI7N1Y+gPFNVyvG/Iphe6NxlR7BuNsVh8DVc/MO 7jHnZuxZywuNjLdA5GJ+CqyDZjYDC+s5alA== X-Received: by 2002:a81:19c5:0:b0:2dc:a22f:80ab with SMTP id 188-20020a8119c5000000b002dca22f80abmr6589687ywz.229.1646666108369; Mon, 07 Mar 2022 07:15:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwB0PXk+S/WSmd7c6SsX99vUUXKlmRslCuleu8jfZIPspRJXVvemUQJ2qylnRJc6hTB/7iXvYD8TmVa445FPoQ= X-Received: by 2002:a81:19c5:0:b0:2dc:a22f:80ab with SMTP id 188-20020a8119c5000000b002dca22f80abmr6589665ywz.229.1646666107979; Mon, 07 Mar 2022 07:15:07 -0800 (PST) MIME-Version: 1.0 References: <20220305203433.1301089-1-jwakely@redhat.com> In-Reply-To: <20220305203433.1301089-1-jwakely@redhat.com> From: Jonathan Wakely Date: Mon, 7 Mar 2022 15:14:56 +0000 Message-ID: Subject: Re: [committed] libstdc++: Ensure __glibcxx_assert_fail has default visibility To: Jonathan Wakely Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="0000000000006e4c6c05d9a254e3" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 15:15:11 -0000 --0000000000006e4c6c05d9a254e3 Content-Type: text/plain; charset="UTF-8" On Sat, 5 Mar 2022 at 20:34, Jonathan Wakely via Libstdc++ wrote: > > Tested powerpc64le-linux, pushed to trunk. > > -- >8 -- > > This ensures there's no linker error if libstdc++ headers are included > following a pragma that sets hidden visibility. > > Similarly for std::__terminate, which is always-inline so shouldn't > matter, but it's not wrong to do this anyway. > > libstdc++-v3/ChangeLog: > > * include/bits/c++config (__glibcxx_assert_fail): Add visibility > attribute. > (__terminate): Likewise. This broke mingw targets. Fixed like so. Tested x86_64-linux, pushed to trunk. --0000000000006e4c6c05d9a254e3 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0gugcer0 Y29tbWl0IDRjYjkzNWNiNjlmMTIwODg5NzVmYTdmNjkwN2M2YWNlMDU4MGUyZGQKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBNb24gTWFyIDcgMTU6 MDc6MDUgMjAyMgoKICAgIGxpYnN0ZGMrKzogVXNlIHZpc2liaWxpdHkgcHJhZ21hcyBpbnN0ZWFk IG9mIGF0dHJpYnV0ZXMgW1BSMTA0ODA3XQogICAgCiAgICBUaGUgX0dMSUJDWFhfUFNFVURPX1ZJ U0lCSUxJVFkgbWFjcm8gaXNuJ3QgZGVmaW5lZCB1bnRpbCBhZnRlciBpbmNsdWRpbmcKICAgIG9z X2RlZmluZXMuaCwgc28gd2UgY2FuJ3QgdXNlIF9HTElCQ1hYX1ZJU0lCSUxJVFkgZWFybHkgaW4g YysrY29uZmlnLgogICAgUmVwbGFjZSB0aGUgdXNlcyBvZiB0aGF0IG1hY3JvIHdpdGggI3ByYWdt YSB2aXNpYmlsaXR5IHB1c2goZGVmYXVsdCkKICAgIGluc3RlYWQuCiAgICAKICAgIGxpYnN0ZGMr Ky12My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAgUFIgbGlic3RkYysrLzEwNDgwNwogICAg ICAgICAgICAqIGluY2x1ZGUvYml0cy9jKytjb25maWcgKF9fdGVybWluYXRlLCBfX2dsaWJjeHhf YXNzZXJ0X2ZhaWwpOgogICAgICAgICAgICBSZXBsYWNlIF9HTElCQ1hYX1ZJU0lCSUxJVFkgb24g ZnVuY3Rpb24gd2l0aCB2aXNpYmlsaXR5IHByYWdtYS4KICAgICAgICAgICAgKF9faXNfY29uc3Rh bnRfZXZhbHVhdGVkKTogQWRkIHZpc2liaWxpdHkgcHJhZ21hLgoKZGlmZiAtLWdpdCBhL2xpYnN0 ZGMrKy12My9pbmNsdWRlL2JpdHMvYysrY29uZmlnIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0 cy9jKytjb25maWcKaW5kZXggNmMxMzRmMTM1MDkuLjI3OThiOTc4NmRjIDEwMDY0NAotLS0gYS9s aWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL2MrK2NvbmZpZworKysgYi9saWJzdGRjKystdjMvaW5j bHVkZS9iaXRzL2MrK2NvbmZpZwpAQCAtMzAyLDE1ICszMDIsMTYgQEAgbmFtZXNwYWNlIHN0ZAog ICB0eXBlZGVmIGRlY2x0eXBlKG51bGxwdHIpCW51bGxwdHJfdDsKICNlbmRpZgogCisjcHJhZ21h IEdDQyB2aXNpYmlsaXR5IHB1c2goZGVmYXVsdCkKICAgLy8gVGhpcyBhbGxvd3MgdGhlIGxpYnJh cnkgdG8gdGVybWluYXRlIHdpdGhvdXQgaW5jbHVkaW5nIGFsbCBvZiA8ZXhjZXB0aW9uPgogICAv LyBhbmQgd2l0aG91dCBtYWtpbmcgdGhlIGRlY2xhcmF0aW9uIG9mIHN0ZDo6dGVybWluYXRlIHZp c2libGUgdG8gdXNlcnMuCiAgIGV4dGVybiAiQysrIiBfX2F0dHJpYnV0ZV9fICgoX19ub3JldHVy bl9fLCBfX2Fsd2F5c19pbmxpbmVfXykpCi0gIF9HTElCQ1hYX1ZJU0lCSUxJVFkoZGVmYXVsdCkK ICAgaW5saW5lIHZvaWQgX190ZXJtaW5hdGUoKSBfR0xJQkNYWF9VU0VfTk9FWENFUFQKICAgewog ICAgIHZvaWQgdGVybWluYXRlKCkgX0dMSUJDWFhfVVNFX05PRVhDRVBUIF9fYXR0cmlidXRlX18g KChfX25vcmV0dXJuX18pKTsKICAgICB0ZXJtaW5hdGUoKTsKICAgfQorI3ByYWdtYSBHQ0Mgdmlz aWJpbGl0eSBwb3AKIH0KIAogI2RlZmluZSBfR0xJQkNYWF9VU0VfRFVBTF9BQkkKQEAgLTUwNiw2 ICs1MDcsNyBAQCBuYW1lc3BhY2Ugc3RkCiAKIG5hbWVzcGFjZSBzdGQKIHsKKyNwcmFnbWEgR0ND IHZpc2liaWxpdHkgcHVzaChkZWZhdWx0KQogICAvLyBJbnRlcm5hbCB2ZXJzaW9uIG9mIHN0ZDo6 aXNfY29uc3RhbnRfZXZhbHVhdGVkKCkuCiAgIC8vIFRoaXMgY2FuIGJlIHVzZWQgd2l0aG91dCBj aGVja2luZyBpZiB0aGUgY29tcGlsZXIgc3VwcG9ydHMgdGhlIGZlYXR1cmUuCiAgIC8vIFRoZSBt YWNybyBfR0xJQkNYWF9IQVZFX0lTX0NPTlNUQU5UX0VWQUxVQVRFRCBjYW4gYmUgdXNlZCB0byBj aGVjayBpZgpAQCAtNTIzLDYgKzUyNSw3IEBAIG5hbWVzcGFjZSBzdGQKICAgICByZXR1cm4gZmFs c2U7CiAjZW5kaWYKICAgfQorI3ByYWdtYSBHQ0MgdmlzaWJpbGl0eSBwb3AKIH0KIAogLy8gRGVi dWcgTW9kZSBpbXBsaWVzIGNoZWNraW5nIGFzc2VydGlvbnMuCkBAIC01NTMsMTMgKzU1NiwxNSBA QCBuYW1lc3BhY2Ugc3RkCiAjIGlmZGVmIF9HTElCQ1hYX1ZFUkJPU0VfQVNTRVJUCiBuYW1lc3Bh Y2Ugc3RkCiB7CisjcHJhZ21hIEdDQyB2aXNpYmlsaXR5IHB1c2goZGVmYXVsdCkKICAgLy8gQXZv aWQgdGhlIHVzZSBvZiBhc3NlcnQsIGJlY2F1c2Ugd2UncmUgdHJ5aW5nIHRvIGtlZXAgdGhlIDxj YXNzZXJ0PgogICAvLyBpbmNsdWRlIG91dCBvZiB0aGUgbWl4LgotICBleHRlcm4gIkMrKyIgX0dM SUJDWFhfTk9SRVRVUk4gX0dMSUJDWFhfVklTSUJJTElUWShkZWZhdWx0KQorICBleHRlcm4gIkMr KyIgX0dMSUJDWFhfTk9SRVRVUk4KICAgdm9pZAogICBfX2dsaWJjeHhfYXNzZXJ0X2ZhaWwoY29u c3QgY2hhciogX19maWxlLCBpbnQgX19saW5lLAogCQkJY29uc3QgY2hhciogX19mdW5jdGlvbiwg Y29uc3QgY2hhciogX19jb25kaXRpb24pCiAgIF9HTElCQ1hYX05PRVhDRVBUOworI3ByYWdtYSBH Q0MgdmlzaWJpbGl0eSBwb3AKIH0KICNkZWZpbmUgX19nbGliY3h4X2Fzc2VydF9pbXBsKF9Db25k aXRpb24pCQkJCVwKICAgaWYgKF9fYnVpbHRpbl9leHBlY3QoIWJvb2woX0NvbmRpdGlvbiksIGZh bHNlKSkJCQlcCg== --0000000000006e4c6c05d9a254e3--