From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 2DDF53857C5F for ; Wed, 20 Oct 2021 18:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DDF53857C5F Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-jgE8sf0PNkGyB4GM2B-jlg-1; Wed, 20 Oct 2021 14:57:15 -0400 X-MC-Unique: jgE8sf0PNkGyB4GM2B-jlg-1 Received: by mail-yb1-f200.google.com with SMTP id e189-20020a2569c6000000b005be95530997so930267ybc.6 for ; Wed, 20 Oct 2021 11:57:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uigBRXnhLyxTQRduxc2OmNJDothbeib2WLaX8FUUiZM=; b=Da4pArphQKoE0XZ21wtPwiLQH9ZYiTwdBk15BarfDsuVPoEVu+uQOU/Aa3Xxk+Nq0g RwQ2lVnmSt5lyewh4SzEfaKobn5+00GckFBmk64k7E3EVsJSBBoQ4cSOZ5AWrTnVW8kX S9ORJVSMGa7oRCdnWvZrFV9mQdFVIbHPJVxMyxeMwpKr3UyrxGzKvmxgezUUFRLIi8T5 i+LsfmOFhlIEaDwPruVCra0W5WvjAkk6dty0Ako6RUocCxH9LDxu6pZpO7i7MOYmsGDx PSGnW71lDRwDvs/gXIxZS/xdU4EoSkjfubfprmNDs3wZMgom4AzmsIx7AX+myvrHnbxc HYLQ== X-Gm-Message-State: AOAM532BG1m8IpKcG9UYevUeNZy1yqGDRF8rqYyGEveR3IwaWI+orEfk ZzbKOB2+cNmXhtQ5q2a4nDlcw6N8VD8AQhL/5qR+wGyvc5TBTEAi4yC5YKVwsBA3L3Ko5KrOFgh WCgPOBj1adjSKWTumNeNQ6enRT37IemY34Q== X-Received: by 2002:a25:cc4a:: with SMTP id l71mr855150ybf.41.1634756235134; Wed, 20 Oct 2021 11:57:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRC+gmsWklUbCSNOURvFIMAP60oqKp6lxj1bMuUtJLmfAouvegwHZyCTiK3EyRMQxcwbVbjFBmX8sKty83LCs= X-Received: by 2002:a25:cc4a:: with SMTP id l71mr855132ybf.41.1634756234977; Wed, 20 Oct 2021 11:57:14 -0700 (PDT) MIME-Version: 1.0 References: <20211020165942.1827062-1-ppalka@redhat.com> In-Reply-To: <20211020165942.1827062-1-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 20 Oct 2021 19:57:03 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement LWG 3535 changes to ranges::join_view To: Patrick Palka Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 18:57:18 -0000 On Wed, 20 Oct 2021 at 18:03, Patrick Palka via Libstdc++ wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk, and branches > after a while? Yes for all. > > libstdc++-v3/ChangeLog: > > * include/std/ranges (join_view::__iter_cat::_S_iter_cat): Adjust > criteria for returning bidirectional_iterator_tag as per LWG3535. > (join_view::_Iterator::_S_iter_concept): Likewise. > --- > libstdc++-v3/include/std/ranges | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges > index 273699aa790..c1519c7dbd5 100644 > --- a/libstdc++-v3/include/std/ranges > +++ b/libstdc++-v3/include/std/ranges > @@ -2523,7 +2523,8 @@ namespace views::__adaptor > using _OuterCat = typename iterator_traits<_Outer_iter>::iterator_category; > using _InnerCat = typename iterator_traits<_Inner_iter>::iterator_category; > if constexpr (derived_from<_OuterCat, bidirectional_iterator_tag> > - && derived_from<_InnerCat, bidirectional_iterator_tag>) > + && derived_from<_InnerCat, bidirectional_iterator_tag> > + && common_range>>) > return bidirectional_iterator_tag{}; > else if constexpr (derived_from<_OuterCat, forward_iterator_tag> > && derived_from<_InnerCat, forward_iterator_tag>) > @@ -2575,7 +2576,8 @@ namespace views::__adaptor > { > if constexpr (_S_ref_is_glvalue > && bidirectional_range<_Base> > - && bidirectional_range>) > + && bidirectional_range> > + && common_range>) > return bidirectional_iterator_tag{}; > else if constexpr (_S_ref_is_glvalue > && forward_range<_Base> > -- > 2.33.1.711.g9d530dc002 >