public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories
Date: Mon, 14 Nov 2022 10:39:33 +0000	[thread overview]
Message-ID: <CACb0b4nmwLE_PxHHQRbvTh+DuK2bGmsq7J33xq-=KxO3ocSt6g@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4nADb3C3c+dpdz7u3D9aOXZ8UuWgE4npOenS8sibY+8BQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Mon, 14 Nov 2022 at 10:29, Jonathan Wakely wrote:
>
> On Sun, 13 Nov 2022 at 18:06, Arsen Arsenović via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > I'm unsure why this issue only started manifesting now with how old this
> > code is, but this should fix it.
> >
> > libstdc++-v3/ChangeLog:
> >
> >         * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA
> >         when installing gdb scripts.
> >         * python/Makefile.in: Regenerate.
>
>
> This looks simple, and more consistent with what we already do. Does
> it solve your issue?

Apparently it helps if I commit a fix after testing it, and don't send
the unfixed commit.

Try *this* one.

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1507 bytes --]

commit 58a8ec0ce8c9231e6d8cc99a0bf8f2afd1e702de
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Nov 14 10:37:58 2022

    libstdc++: Add missing mkdirs for installing python files for debug lib
    
    libstdc++-v3/ChangeLog:
    
            * python/Makefile.am (intall-data-local): Use mkdirs_p for debug
            libdir.
            * python/Makefile.in: Regenerate.

diff --git a/libstdc++-v3/python/Makefile.am b/libstdc++-v3/python/Makefile.am
index f523d3a44dc..df6bf508210 100644
--- a/libstdc++-v3/python/Makefile.am
+++ b/libstdc++-v3/python/Makefile.am
@@ -62,5 +62,6 @@ install-data-local: gdb.py
 	$(INSTALL_DATA) gdb.py $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \
 	if [ -n "$(debug_gdb_py)" ]; then \
 	  sed "/^libdir = /s;'$$;/debug';" gdb.py > debug-gdb.py ; \
+	  $(mkdir_p) $(DESTDIR)$(toolexeclibdir)/debug ; \
 	  $(INSTALL_DATA) debug-gdb.py $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \
 	fi
diff --git a/libstdc++-v3/python/Makefile.in b/libstdc++-v3/python/Makefile.in
index 05e79b5ac1e..c527e6cf186 100644
--- a/libstdc++-v3/python/Makefile.in
+++ b/libstdc++-v3/python/Makefile.in
@@ -627,6 +627,7 @@ install-data-local: gdb.py
 	$(INSTALL_DATA) gdb.py $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \
 	if [ -n "$(debug_gdb_py)" ]; then \
 	  sed "/^libdir = /s;'$$;/debug';" gdb.py > debug-gdb.py ; \
+	  $(mkdir_p) $(DESTDIR)$(toolexeclibdir)/debug ; \
 	  $(INSTALL_DATA) debug-gdb.py $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \
 	fi
 

  reply	other threads:[~2022-11-14 10:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 18:05 Arsen Arsenović
2022-11-13 19:42 ` Jonathan Wakely
2022-11-13 20:29   ` Bernhard Reutner-Fischer
2022-11-14 10:16     ` Jonathan Wakely
2022-11-14 10:29 ` Jonathan Wakely
2022-11-14 10:39   ` Jonathan Wakely [this message]
2022-11-14 13:15     ` Arsen Arsenović
2022-11-14 14:13       ` Jonathan Wakely
2022-11-14 14:19         ` Jonathan Wakely
2022-11-14 15:56           ` Arsen Arsenović
2022-11-14 16:00             ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4nmwLE_PxHHQRbvTh+DuK2bGmsq7J33xq-=KxO3ocSt6g@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).