Re: [PATCH] Move std::search into algobase.h

[Jonathan Wakely <jwakely@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

On Fri, 2 Jun 2023 at 10:47, François Dumont <frs.dumont@gmail.com> wrote:

> Ok, push done.
>

Thanks.


> Even after full rebuild those tests are still UNRESOLVED on my system.
>
What is the error in the log?

What is your system? How and where did you install "OMP"?

Does the libgomp directory exist in the GCC build tree, at the same level
as libstdc++-v3?

e.g. in $objdir/x86_64-pc-linux-gnu/libgomp or equivalent?

That directory should contain omp.h and .libs/libgomp.* which will be used
by the libstdc++ testsuite for the check-parallel target (see the
libgomp_flags variable which sets the paths to find libgomp in the build
tree).

But because that test only runs for normal mode (not parallel mode) it
doesn't use libgomp_flags, and so it will only find omp.h if it already
exists in the compiler's default include paths, which will happen if you've
already run "make install" on the GCC built with libgomp enabled.

If you haven't enabled libgomp, or you haven't installed the new GCC yet,
then the __has_include(<omp.h>) should fail, and so the test does nothing
and so should just PASS. If it's UNRESOLVED for you then that implies it's
finding an <omp.h> header, but probably not the one from GCC, so it fails
to compile. I think that's due to how you've installed "OMP" (whatever that
means ... I don't think you've installed libgomp and so I don't think you
should have done that ... maybe you installed Clang's libomp headers
instead and GCC is finding those somehow?)