From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 36AF83858D3C for ; Fri, 2 Jun 2023 11:30:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36AF83858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685705416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8A4AJlxN+aJE9d7TUItdtuENbFi4e7ETdFPF4zNYQk8=; b=L4dcbb1g6h/FkKcvPO+gOXltdfga/N9hqoTBdVaW3f8sgUagrFOuITSeRI+iJ3XbPHc/98 PeMaFqma04DFLLyE8CxkaiSkv0ETuJfhiBtPWCiCnecYpgvF4wmYYSG+aEgRO44jVFXG7h O4D/bz8/mKABqZ8G93EHgWS3JHnT5J4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-QLJkFG48OjCONyK9DjeYgA-1; Fri, 02 Jun 2023 07:30:15 -0400 X-MC-Unique: QLJkFG48OjCONyK9DjeYgA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4f5847463baso1606517e87.3 for ; Fri, 02 Jun 2023 04:30:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685705414; x=1688297414; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8A4AJlxN+aJE9d7TUItdtuENbFi4e7ETdFPF4zNYQk8=; b=Ds5/UDbItozoEyDhlngtwuqOL1K732gWJ4hKlsH0atnGc5C87gcwb9Z11LMegO80VH P+gGcyH2OeU5oeGQVM9S9Zzo/5R32GsmnLvLzyNLizmcLnaMfsQLl+DZ1TwSUMH8dVwz pGaSb6uxQk55RwM9gWIGfPV0Sx3DU6eAAZ2ty62LLNtJ5aIheSYsMMEB8zD873Bd/7DK ex4/JLcT5vk3jhFiwEBvtkynFJ4KbkUNGs2lPSp7L/FLt8FMeOTAGKZY+88vnCcGf7ww id/9iOXxZpYRGrJK3PIjgC2FCG/mWtPnwWqm54f2Ze395Yiwfj8kmlJFXY1e7XGzHI2S TmSw== X-Gm-Message-State: AC+VfDznjAkBSSFW8m/KTnWs5w5V9nnXejhf7T/b55udljVNs4bKnlQj ZH9juUaMYHhOqGBtkh3eUVzKorwYPPtxUgXwvtC3UfOmE4J2aHjM4raGxPdCBVf5ntwOdoQSxQ/ vyltUDB7/GWGn/0wVBe4r3xmV/fzZ2d5uCQ== X-Received: by 2002:a05:651c:14d:b0:2af:2908:8ff3 with SMTP id c13-20020a05651c014d00b002af29088ff3mr1310355ljd.33.1685705414128; Fri, 02 Jun 2023 04:30:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7tVSimzkF5n/3sU6yKj2WVI8cduP3BbujVB4QpQdmmNJbjRXJHJWjsJTEHxYMUT8cbiPNUwU3VMeCfXIJnQ1E= X-Received: by 2002:a05:651c:14d:b0:2af:2908:8ff3 with SMTP id c13-20020a05651c014d00b002af29088ff3mr1310344ljd.33.1685705413784; Fri, 02 Jun 2023 04:30:13 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> <12cad432-888f-6db7-152a-89c5a17e4ac8@gmail.com> In-Reply-To: <12cad432-888f-6db7-152a-89c5a17e4ac8@gmail.com> From: Jonathan Wakely Date: Fri, 2 Jun 2023 12:30:02 +0100 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000628c9d05fd23e002" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000628c9d05fd23e002 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2 Jun 2023 at 10:47, Fran=C3=A7ois Dumont wr= ote: > Ok, push done. > Thanks. > Even after full rebuild those tests are still UNRESOLVED on my system. > What is the error in the log? What is your system? How and where did you install "OMP"? Does the libgomp directory exist in the GCC build tree, at the same level as libstdc++-v3? e.g. in $objdir/x86_64-pc-linux-gnu/libgomp or equivalent? That directory should contain omp.h and .libs/libgomp.* which will be used by the libstdc++ testsuite for the check-parallel target (see the libgomp_flags variable which sets the paths to find libgomp in the build tree). But because that test only runs for normal mode (not parallel mode) it doesn't use libgomp_flags, and so it will only find omp.h if it already exists in the compiler's default include paths, which will happen if you've already run "make install" on the GCC built with libgomp enabled. If you haven't enabled libgomp, or you haven't installed the new GCC yet, then the __has_include() should fail, and so the test does nothing and so should just PASS. If it's UNRESOLVED for you then that implies it's finding an header, but probably not the one from GCC, so it fails to compile. I think that's due to how you've installed "OMP" (whatever that means ... I don't think you've installed libgomp and so I don't think you should have done that ... maybe you installed Clang's libomp headers instead and GCC is finding those somehow?) --000000000000628c9d05fd23e002--