From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 183D63856961 for ; Fri, 9 Jun 2023 09:06:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 183D63856961 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=79apwGx2kEjTZrYvk4mQZUHsf073NqN/pT8iZUPG9r4=; b=OfoY9v2Cyn145ti4JHzeB1OlFgk6Xm6CSqGvIVHLsovBdWkxn+CkHu0CoZoZ+qka9AA23m HUXqW+zNGNmi8nr0n+dk4dbSdnbFViQhqOU3twsz6gmQI1EpzVp79kbZSc4NIsQIPihmy3 O40PFgaXwsbySPf27mM6gN/9wdsW1kE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-664oyg4FN8ec1P1fi1KjsA-1; Fri, 09 Jun 2023 05:06:48 -0400 X-MC-Unique: 664oyg4FN8ec1P1fi1KjsA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b1b122976fso11221511fa.3 for ; Fri, 09 Jun 2023 02:06:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301607; x=1688893607; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=79apwGx2kEjTZrYvk4mQZUHsf073NqN/pT8iZUPG9r4=; b=H7i9tbel5TqKbpSqw/h4JnqdxTRLO78kw2LCQNpVGszsJf5hNyHaLUV1o6ZFIX6vtD 95jj/qMfLaQfcuftv9wU2jXVCbBO6luRFI5drgwfTVhBjTytNu3uKh8LUwkGUbUVjy2K ISLLbfH7BM8Eu42+14Yizeu/2u/ASA1e/s6IriDkY8Qq3qnBpDwNf5JATfeLRzHHUQIg SfspCNKK0tIwKKY6OCJrMffbs8uAcIpMlxqYZBjPaUrZlexorKUjUIrX4AHew7dIhGX+ eMfr9Ckz9bc+1cajMqichwC4KMVXIWYZ35Pm7Zdgas/PZpbSCJ2catNr0SkPoqtiYrbb K1kA== X-Gm-Message-State: AC+VfDxxYgKDvOpNJmFM/+AtUuaE1RU6Mxa97w3jUGNZwHjp6lkZ+8aD yczThw5AV3+8JCQ4aRlR4I2rjAvArTfvJ935UDsAWV9TZGo4M8T4pMNK9Ke2NlIoHhV93fEodRY x0Bu/QR3uLNZFZFXvxH9AmeZeuOzzGTCd/Q== X-Received: by 2002:a2e:8795:0:b0:2a8:bdff:8556 with SMTP id n21-20020a2e8795000000b002a8bdff8556mr586043lji.13.1686301606922; Fri, 09 Jun 2023 02:06:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4pR8MuOGGhPa192qX7YzPD6XVxn6nVH7r7bamAKWfrj2KNKmUg/+fSW9IsWCU3WB5nG6qqj/KGx5ArZGdulgQ= X-Received: by 2002:a2e:8795:0:b0:2a8:bdff:8556 with SMTP id n21-20020a2e8795000000b002a8bdff8556mr586030lji.13.1686301606634; Fri, 09 Jun 2023 02:06:46 -0700 (PDT) MIME-Version: 1.0 References: <20230524185559.1285583-1-jason@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 9 Jun 2023 10:06:34 +0100 Message-ID: Subject: Re: [PATCH RFC] c++: use __cxa_call_terminate for MUST_NOT_THROW [PR97720] To: Richard Biener Cc: Jason Merrill , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003f7eba05fdaeb0f1" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003f7eba05fdaeb0f1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 9 Jun 2023 at 10:03, Richard Biener wrote: > On Thu, Jun 8, 2023 at 3:14=E2=80=AFPM Jonathan Wakely via Gcc-patches > wrote: > > > > On Fri, 26 May 2023 at 10:58, Jonathan Wakely wrote: > > > > > > > > > > > On Wed, 24 May 2023 at 19:56, Jason Merrill via Libstdc++ < > > > libstdc++@gcc.gnu.org> wrote: > > > > > >> Middle-end folks: any thoughts about how best to make the change > > >> described in > > >> the last paragraph below? > > >> > > >> Library folks: any thoughts on the changes to __cxa_call_terminate? > > >> > > > > > > I see no harm in exporting it (with the adjusted signature). The "loo= ks > > > standard but isn't" name is a little unfortunate, but not a big deal. > > > > > > > Jason, do you have any objection to exporting __cxa_call_terminate for > GCC > > 13.2 as well, even though the FE won't use it? > > > > Currently both gcc-13 and trunk are at the same library version, > > libstdc++.so.6.0.32 > > > > But with this addition to trunk we need to bump that .32 to .33, meaning > > that gcc-13 and trunk diverge. If we want to backport any new symbols > from > > trunk to gcc-13 that gets trickier once they've diverged. > > But if you backport any new used symbol you have to bump the version > anyway. So why not bump now (on trunk)? > We've already bumped it once since 13.1, and until 13.2 is released we aren't committed to freezing the new version. I think we can add this __cxa_call_terminate symbol to the version currently used by 13.1.1 without problems. And if we want to backport another new symbol before 13.2, we can do that too (unless it would be too difficult for distros already shipping 13.1.1, but I don't think that applies in this case). --0000000000003f7eba05fdaeb0f1--