From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 29900385842A for ; Thu, 1 Jun 2023 12:06:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29900385842A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685621167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VC3uQYWi117BpW/fJaTqLOMuuHiStqoXe/MQOYhSLDA=; b=AhTT3jYQtorV47B262Ua1DB2NI8BdNSKBCFTmw7nfv4kGzrUQaGLZ0ZxGomd7T7bRONl73 o7eYyJObtC8Legsk9Er3ttCQvnhI7s6axNJrJoiUXiJu5H1wxa7ZiW08cCfvAHiL1tthvF yX/XkAJboI1ioig5kMRIxWuZJgN379w= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-TGv215KbPxyyCVlBlvX6LQ-1; Thu, 01 Jun 2023 08:05:58 -0400 X-MC-Unique: TGv215KbPxyyCVlBlvX6LQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2af570dc8daso6413481fa.2 for ; Thu, 01 Jun 2023 05:05:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685621157; x=1688213157; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VC3uQYWi117BpW/fJaTqLOMuuHiStqoXe/MQOYhSLDA=; b=dh+kE6rXFFdUSoUJMRuaJNwDPH4TuEjw0Qv/oRExFXIq2+mh+eXBlyfYqprdoODmPN ldC6D/j2flrQm6bUracP32yC97V0mBvUl0PLkAXNNF6FItMB95gabmHu4rh328q4e4ty e5yyVVZRotp7d4cu/jf9K+sU2uieX4WJCLbe5r5h7CAKB9HVced90sMd8R7qpgjnxwnR 9uf0TP9oMzY+aM87leJuUPTcWTlh2TqN7iBsoxcWUm/f5433FNu4QfnaUoz8nd7SkHKt nAV6OuZS/y6APQc6MwY2ZzDa1lJYgcOs2stYUZd5QllIvdWUceA0d7KrMV9W8jAfoU1d z/hQ== X-Gm-Message-State: AC+VfDyh1BaeXy8xLlpHDfZcppc55CApqcOtuVtFXaW1pgHr+82Y5TLA EpWRBEie6qDEp9zTaAXMcH+wI18g+N11CFzHAGoE/IGQNu71283P8ybxskqiZtJEjcmi2KuR2x9 SnoO1hz1d0pPFpv9cnD1CFYG7ILu4Ew8taw== X-Received: by 2002:a2e:820c:0:b0:2ad:9539:214c with SMTP id w12-20020a2e820c000000b002ad9539214cmr4306712ljg.6.1685621157163; Thu, 01 Jun 2023 05:05:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5JC+Eg1yHJuZ0dZ4ID23+9r3w50dl2TVldQsLnKkZC0R7QDTsAkBW3pywSw17RsQmxd4uE0s6tJXRiTVzwdEM= X-Received: by 2002:a2e:820c:0:b0:2ad:9539:214c with SMTP id w12-20020a2e820c000000b002ad9539214cmr4306683ljg.6.1685621156814; Thu, 01 Jun 2023 05:05:56 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 1 Jun 2023 13:05:45 +0100 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: Rainer Orth Cc: Jonathan Wakely via Gcc-patches , =?UTF-8?Q?Fran=C3=A7ois_Dumont?= , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000047321f05fd104211" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000047321f05fd104211 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 1 Jun 2023 at 12:52, Rainer Orth wrote: > Jonathan Wakely via Gcc-patches writes: > > > On Wed, 31 May 2023 at 18:39, Fran=C3=A7ois Dumont via Libstdc++ < > > libstdc++@gcc.gnu.org> wrote: > > > >> libstdc++: Reduce inclusion to > >> > >> > >> Move the std::search definition from stl_algo.h to stl_algobase.h and > use > >> the later in . > >> > >> For consistency also move std::__parallel::search and associated helpe= rs > >> from > >> to so that > >> std::__parallel::search > >> is accessible along with std::search. > >> > >> libstdc++-v3/ChangeLog: > >> > >> * include/bits/stl_algo.h > >> (std::__search, std::search(_FwdIt1, _FwdIt1, _FwdIt2, > >> _FwdIt2, _BinPred)): Move... > >> * include/bits/stl_algobase.h: ...here. > >> * include/std/functional: Replace include by > >> . > >> * include/parallel/algo.h (std::__parallel::search<_FIt1, > >> _FIt2, _BinaryPred>) > >> (std::__parallel::__search_switch<_FIt1, _FIt2, > >> _BinaryPred, _ItTag1, _ItTag2>): > >> Move... > >> * include/parallel/algobase.h: ...here. > >> * include/std/functional: Remove and > >> > >> includes. Include . > >> > >> Tested under Linux x86_64. > >> > >> Ok to commit ? > >> > > > > OK > > This seems to have caused > > +FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess errors) > +FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess errors) > > on i386-pc-solaris2.11: > I think it affects all targets. > > Excess errors: > /var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc= ++-v3/include/parallel/algobase.h:496: > error: '__search_template' is not a member of '__gnu_parallel'; did you > mean '__find_template'? > > Rainer > > -- > > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University > > --00000000000047321f05fd104211--