From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29175 invoked by alias); 19 Oct 2012 09:45:31 -0000 Received: (qmail 29162 invoked by uid 22791); 19 Oct 2012 09:45:30 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 09:45:25 +0000 Received: by mail-vc0-f175.google.com with SMTP id p1so227204vcq.20 for ; Fri, 19 Oct 2012 02:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=nAcv/AFefBzVl5kKND/X5G8nIst7398PGWZuQIYJb8U=; b=BQdSdghe9IG5VTTmUS9JMHYbjhU+2F4c+ABln0nzVqB7XOCAgqeaIwLrHlWurYW/yT ZWDQSa5kGnq96dvICgHLTVy23X9MvjdGBxvIpg1GHzj2SyNJXtJdkRrsgQSlDOj1T8+e S8uyQcElw5ixSJDRntUcUsjlKbwJz84ctTpPU5vPNhBtFSE1pH4HYPFmUcsVwHiHxTbA 5/app6MS9ZVLXMGlZTPcMLknKaYl+iUuYb2cYSmgx0t5LypCqf5MOy2q29WTKHt50l1L UaHTvApfxS+AK7KfYFSQGPvQBa/KgrYWqmoYrvVIjb9Kf3fC0nqh9qpCzrNpq1KyNhW4 tLfg== MIME-Version: 1.0 Received: by 10.220.220.203 with SMTP id hz11mr753481vcb.50.1350639924397; Fri, 19 Oct 2012 02:45:24 -0700 (PDT) Received: by 10.58.114.232 with HTTP; Fri, 19 Oct 2012 02:45:24 -0700 (PDT) In-Reply-To: References: Date: Fri, 19 Oct 2012 10:29:00 -0000 Message-ID: Subject: Re: [PATCH, ARM] Fix PR target/54892 - [4.7/4.8 Regression], ICE in extract_insn, at recog.c:2123 From: Zhenqiang Chen To: ramrad01@arm.com Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmGQgQgqSdzlvBzb76NN3AeUMMvq3xYiGsLWSn2Do1HwLwoZUr1dv1yh4j8UgLO4oP5jejx Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg01786.txt.bz2 On 19 October 2012 14:53, Ramana Radhakrishnan wrote: > On Fri, Oct 19, 2012 at 7:46 AM, Zhenqiang Chen > wrote: >> Hi, >> >> In function arm_expand_compare_and_swap, oldval is converted to SImode >> when its "mode" is QImode/HImode. After "FALLTHRU" to "case SImode", >> we should use "SImode", other than "mode" (which is QImode/HImode). >> And INSN atomic_compare_and_swap_1 expects the operand in >> SImode. >> >> No make check regression. >> >> Is it OK for 4.7 and trunk? > > Makes sense , OK for both. > Thanks. Committed to 4.7 and trunk. -Zhenqiang