public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zhenqiang Chen <zhenqiang.chen@linaro.org>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <rearnsha@arm.com>,
	Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: [PATCH, ARM] ICE when building kernel raid6 neon code
Date: Wed, 15 Jan 2014 10:04:00 -0000	[thread overview]
Message-ID: <CACgzC7Dhzimyj0A760jDOUjRrW=CBsNUaycZWDaadOFKUqdNXQ@mail.gmail.com> (raw)

Hi,

The patch fixes ICE when building kernel raid6 neon code.

lib/raid6/neon4.c: In function 'raid6_

neon4_gen_syndrome_real':
lib/raid6/neon4.c:113:1: internal compiler error: in
dwarf2out_frame_debug_adjust_cfa, at dwarf2cfi.c:1090
 }

https://bugs.launchpad.net/gcc-linaro/+bug/1268893

Root cause:
When expanding epilogue, REG_CFA_ADJUST_CFA NOTE is added to handle
dwarf info issue for shrink-wrap. But for TARGET_APCS_FRAME,
shrink-wrap is disabled. And not all dwarf info in
arm_expand_epilogue_apcs_frame are correctly updated.
arm_emit_vfp_multi_reg_pop is called by both
arm_expand_epilogue_apcs_frame and arm_expand_epilogue. So we should
not add the NOTE in arm_emit_vfp_multi_reg_pop if shrink-wrap is not
enabled.

Boot strap and no make check regression on ARM Chromebook.

OK for trunk?

Thanks!
-Zhenqiang

ChangeLog:
2014-01-15  Zhenqiang Chen  <zhenqiang.chen@linaro.org>

        * config/arm/arm.c (arm_emit_vfp_multi_reg_pop): Do not add
        REG_CFA_ADJUST_CFA NOTE if shrink-wrap is not enabled.

diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index 18196b3..1ccb796 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -19890,8 +19890,12 @@ arm_emit_vfp_multi_reg_pop (int first_reg,
int num_regs, rtx base_reg)
   par = emit_insn (par);
   REG_NOTES (par) = dwarf;

-  arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs,
-                              base_reg, base_reg);
+  /* REG_CFA_ADJUST_CFA NOTE is added to handle dwarf info issue when
+     shrink-wrap is enabled.  So when shrink-wrap is not enabled, we should
+     not add the note.  */
+  if (flag_shrink_wrap)
+    arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs,
+                                base_reg, base_reg);
 }

 /* Generate and emit a pattern that will be recognized as LDRD
pattern.  If even

             reply	other threads:[~2014-01-15 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 10:04 Zhenqiang Chen [this message]
2014-01-15 11:37 ` Richard Earnshaw
     [not found] <xilhiby0142cs0le48qgs52q.1389786995121@email.android.com>
2014-01-16  5:44 ` Zhenqiang Chen
2014-01-27 17:07   ` Ramana Radhakrishnan
2014-01-28  3:37     ` Zhenqiang Chen
2014-03-06  8:09       ` Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACgzC7Dhzimyj0A760jDOUjRrW=CBsNUaycZWDaadOFKUqdNXQ@mail.gmail.com' \
    --to=zhenqiang.chen@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ramana.radhakrishnan@arm.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).