From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16064 invoked by alias); 17 May 2012 16:27:24 -0000 Received: (qmail 16036 invoked by uid 22791); 17 May 2012 16:27:20 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f47.google.com (HELO mail-vb0-f47.google.com) (209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 May 2012 16:27:07 +0000 Received: by vbbfr13 with SMTP id fr13so2096366vbb.20 for ; Thu, 17 May 2012 09:27:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=yVsykgFva4wUtLpSJ+RnwzgeSKAjJNEOg2iGs9AErj8=; b=Sw174p9kWvakfOcauKdgfdYl98iuShAjfDdC1kCh3xOnr73JdWdYgW/aZWia7TNtrs P9jeNICZDpfC3PxepCsMeQbEwGLLSwZI2ng6p+1De2R1MSG5BCXLp/r7HMwRuaQFRsYF hqFLzb3lCHUvCLn60tBbizivCCMeN6XpLAIIvivW9//acgSiXE/LjizuH0VkuJWG/Ite G/UjzBBqJ4Nn3XpolyJS1M8iU7ss0bHJkSW9PfIyj4sBiNLuNYj+pIhqvRnpBoQf44Na YmfFvzyexiDxAUk/5Io8QYxQQEjntizXV9qpKSjSiI57xabK8h378T2yaDgKYvR/0ENm lrQw== Received: by 10.52.68.37 with SMTP id s5mr4295469vdt.7.1337272026891; Thu, 17 May 2012 09:27:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.68.37 with SMTP id s5mr4295454vdt.7.1337272026569; Thu, 17 May 2012 09:27:06 -0700 (PDT) Received: by 10.52.21.97 with HTTP; Thu, 17 May 2012 09:27:06 -0700 (PDT) In-Reply-To: <20cf303ddc7c4238bc04c02ff779@google.com> References: <20cf303ddc7c4238bc04c02ff779@google.com> Date: Thu, 17 May 2012 16:27:00 -0000 Message-ID: Subject: Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060) From: =?UTF-8?B?SGFuIFNoZW4o5rKI5ra1KQ==?= To: asharif@google.com, jingyu@google.com, dnovillo@google.com Cc: gcc-patches@gcc.gnu.org, carrot@google.com, reply@codereview-hr.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQks3nrh9MJc01Ei3O/sTOpqdILFFMn1dPyrjLUD4rT5wqd7a3sDJTksLW7D+lF8lnWhEhSaFI7SecxJCLnLjOEuB+fQ7JYmgNl/kJACMrfqGrdkTH1J669Mmc8SDtLfIrEp7kMXFFMhZHpEYERD1zT4AHrQHg== X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-05/txt/msg01220.txt.bz2 Hi, ok for approval? Thanks, -Han On Wed, May 16, 2012 at 4:49 PM, wrote: > On 2012/05/16 23:30:28, Diego Novillo wrote: > >> On 12-05-16 19:22 , mailto:jingyu@google.com wrote: >> > In my opinion, gcc/ChangeLog is for upstream commits only. >> > It is fine that you want to port upstream gcc/ChangeLog as well. > > Just >> >> > remove your identities >> > +2012-05-11 Han Shen >> >> > + >> > + Backported r187569 from branches/google/gcc-4_6. > > >> The convention for branches is that all the commits to them should get > > >> ChangeLog entries in the file ChangeLog. > > >> where is generally the basename of the branch URL, though > > >> it is sometimes changed slightly. =A0In the google branches we use the >> convention 'google-' for all the branches under google/* > > > >> Diego. > > > Thanks, Jing and Diego. > > Reverted gcc/ChangeLog. > > Regards, > -Han > > http://codereview.appspot.com/6210060/ --=20 Han Shen=A0| =A0Software Engineer=A0| =A0shenhan@google.com=A0| =A0+1-650-4= 40-3330