From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31433 invoked by alias); 14 Jan 2016 22:15:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31399 invoked by uid 89); 14 Jan 2016 22:14:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f51.google.com Received: from mail-oi0-f51.google.com (HELO mail-oi0-f51.google.com) (209.85.218.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 14 Jan 2016 22:14:59 +0000 Received: by mail-oi0-f51.google.com with SMTP id k206so125117355oia.1 for ; Thu, 14 Jan 2016 14:14:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=wuENkhGDqRELgwfnWcwq0L+mNNQgsqR7rRB2ffV40Qk=; b=hNnOJoUQRDQFd1rr+z5SjmHb7AdtekCSJ8SzLAUqNPcMrD9V54MSFC3whCKxCdUFvK btIS7jZjazcoKxsfFZErKkkzbf1XkXOYpC2aIhylb6UBxoDQfEdom9FQLZslDO0CjDxD uLOJAiieigWxZCqhkTohCod12Vgolj4rNGcPitRuUQZXbuQas/ioxLaaEle9iqg5y0/D hnDI9WLaTzCCDjempT2PPKUUSfFOJyAzJzYI1CzHfHMqCfhMRfYmlWwho4hm/ftCd7Xl Xg1owY0b0/yvsxpsS2NeDAG4hduPjhS0RgrtPy/nmerxekL8Oex/Y6VZxxC1eqiUGuEa Qwkw== X-Gm-Message-State: ALoCoQlz52U/xfx8ElBUeJVxYQ70vDQkPBwGVnnEzbiJLoOgp+fnNzZ2fo8vKXyl5VT/8+ssrmz8Io8BYuRTW8uyPUQpyKln7Q== MIME-Version: 1.0 X-Received: by 10.202.196.67 with SMTP id u64mr5254886oif.94.1452809697074; Thu, 14 Jan 2016 14:14:57 -0800 (PST) Received: by 10.202.75.147 with HTTP; Thu, 14 Jan 2016 14:14:57 -0800 (PST) In-Reply-To: <569819B2.7050007@redhat.com> References: <569819B2.7050007@redhat.com> Date: Thu, 14 Jan 2016 22:15:00 -0000 Message-ID: Subject: Re: [cilkplus] Fix cilk_spawn gimplification bug (PR cilkplus/69048) From: Ryan Burn To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Jason Merrill , igor.zamyatin@intel.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00988.txt.bz2 Could you push please? I don't have write access. Thanks - Ryan. On Thu, Jan 14, 2016 at 4:57 PM, Jeff Law wrote: > On 01/14/2016 02:19 PM, Ryan Burn wrote: >> >> This patch adds a missing cleanup point to cilk_spawn expressions to >> prevent an ICE when calling functions that return types with >> non-trivial destructors. >> >> Bootstrapped and regression tested on x86_64-linux. >> >> 2015-01-14 Ryan Burn >> >> PR c++/69048 >> * cilk.c (create_cilk_wrapper_body): Call >> fold_build_cleanup_point_expr to add missing cleanup point. >> >> * gcc/testsuite/g++.dg/cilk-plus/CK/pr69048.cc: New test > > I thought something was horribly wrong for a few minutes. STMT inside > cilk_create_wrapper_body is a tree, not a gimple statement. So my worries > were unfounded :-) > > OK for the trunk. > jeff