From: Alexander Ivchenko <aivchenk@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [testsuite, i386] Reimplementing array comparison in avx2-vpop-check.h
Date: Thu, 18 Apr 2013 13:48:00 -0000 [thread overview]
Message-ID: <CACysShgUi8LT-hiBV4xnzoiTTpHAZmLc3FhB_D21b2PhNQTYfw@mail.gmail.com> (raw)
In-Reply-To: <CAFiYyc32JaXAx3FcYbYNfLNvxpjTJaMnu4p_np7ptrcSNvjmpg@mail.gmail.com>
Yep, that also works.
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 64ffe8f..7efc3f1 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2013-04-18 Grigoriy Kraynov <grigoriy.kraynov@intel.com>
+
+ * gcc.target/i386/avx2-vpop-check.h: volatility is casted away in
+ memcmp().
+
2013-04-18 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/56984
diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
index 143b54da..02c879e 100644
--- a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
+++ b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
@@ -47,7 +47,7 @@ avx2_test (void)
gen_pop ();
check_pop ();
- if (memcmp (c, c_ref, SIZE * sizeof (TYPE)))
+ if (memcmp (c, (void *) c_ref, SIZE * sizeof (TYPE)))
abort();
}
}
The fix is pretty obvious, but still.. is it OK for trunk?
thanks,
Alexander
2013/4/11 Richard Biener <richard.guenther@gmail.com>:
> On Thu, Apr 11, 2013 at 1:58 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>> Hi,
>>
>> Usually <stdlib.h> does not include <string.h> but on bionic it is
>> historically included. memcmp() reacts on a volatile argument
>> differently, depending on whether <string.h> is included or not. If it
>> is included, then the compiler will generate a warning:
>> warning: passing argument 2 of 'memcmp' discards 'volatile' qualifier
>> from pointer target type [enabled by default]
>>
>> In avx2-vpop-check.h we compare two arrays using memcmp(), and since
>> one of them is declared as volatile we have test-fails because of that
>> warning. The following patch reimplements the comparison using just
>> for-loop:
>>
>> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
>> index 943be90..9b08eb0 100644
>> --- a/gcc/testsuite/ChangeLog
>> +++ b/gcc/testsuite/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2013-04-11 Grigoriy Kraynov <grigoriy.kraynov@intel.com>
>> +
>> + * gcc.target/i386/avx2-vpop-check.h: memcmp() replaced by for loop.
>> +
>> 2013-04-11 Paolo Carlini <paolo.carlini@oracle.com>
>>
>> PR c++/54216
>> diff --git a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
>> b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
>> index 143b54da..921ed0b 100644
>> --- a/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
>> +++ b/gcc/testsuite/gcc.target/i386/avx2-vpop-check.h
>> @@ -47,7 +47,8 @@ avx2_test (void)
>> gen_pop ();
>> check_pop ();
>>
>> - if (memcmp (c, c_ref, SIZE * sizeof (TYPE)))
>> - abort();
>> + for (i = 0; i < SIZE; ++i)
>> + if (c[i] != c_ref[i])
>> + abort();
>> }
>> }
>>
>>
>> is it OK?
>
> Just cast away the volatileness? memcmp (c, (void *)c_ref, ...)?
>
> Richard.
>
>> thanks,
>> Alexander
next prev parent reply other threads:[~2013-04-18 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 12:37 Alexander Ivchenko
2013-04-11 13:10 ` Richard Biener
2013-04-18 13:48 ` Alexander Ivchenko [this message]
2013-04-18 13:49 ` Uros Bizjak
2013-04-18 18:25 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACysShgUi8LT-hiBV4xnzoiTTpHAZmLc3FhB_D21b2PhNQTYfw@mail.gmail.com \
--to=aivchenk@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).