From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id BD0E138582AF for ; Mon, 15 Jan 2024 13:05:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD0E138582AF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD0E138582AF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705323930; cv=none; b=ROtzNQZn05B+SNa1ZcWUqgUD+ZxvNm/pTNVMLfuvA6ihAe5GLJihnuCDMGMUfoSg60hFoWwA7VHMxGR5NYph8kSIrxfgJQpJ6/xqEU67CcaIYf9igm1vYdfr8Gt7bWCF5/QwaD1bR1YHqbtUkVoiE9YQUE7xPMuDSpOAxmau1ig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705323930; c=relaxed/simple; bh=e2PwDudce86XL2THnWwxBEAM94f5amXx+Ldsv5sJNOg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xfgex6OVSehfsypay7pm9CvMKYWKZvBpEYFSpguBM09yt1BmoHujSlMjgmj5jdhxBvOiZyVtzRSZkDpBLnbT8YNtRu9i3blrZfQgV26scmQRnG3no+ZFCrGR6Gg3zF9zpR8CtVR7DkjVBWWVUzdiuOGVI/LzZrugNXEHompd64A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6d9ab48faeaso1479825b3a.1 for ; Mon, 15 Jan 2024 05:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705323923; x=1705928723; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+RMuj3AyTHucBA3EHXrb3DxpV2wfUhFC0SxY1YApR0I=; b=EpDI4lEhqkVo4ghEe5vM4B4AEODTRuE09P8o9oFPcoq9LEr1fVbPWas3qoqqPa7rF/ 80nTqVZVq4MBLrp92QydDdPBE43WoD4HGDYNJmCIvB6GB4OJA7cOlFTY/krDAtioN8gE jQK1fM/giKtljTpLNAN1aXPih0EtNNhkZLO/57PEw0VvAGnjPRVSyRZevui/rgehYpPc Qxyp8p2hFyVPyIOMsmgZSmVPkdINnwGcNCMw2VYEV0i6WE8VlJMll6Frqw0eJeJWcLVL g82yMd9w9pO20FpQqEiZvcA0vDRjo8mrUvi1/UAEwxUKHrOATU+Qt5UPpQZ+2BErXY5b 1jrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705323923; x=1705928723; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+RMuj3AyTHucBA3EHXrb3DxpV2wfUhFC0SxY1YApR0I=; b=dwo+f9QDu7aw7Z5Ju+XCl43zqm1yvIDov9Q1uD3L3Ml04Jm3A8/kVAaW5McZYXkE/9 YMi801iQfnnC2DGiLYY3MkDH11KDDW0a8b7KlRbehu6zCHDsLr8ngyYw+WTetm1N5c5g vnC4/eYZgcFYP/1uZSjSdiHb6uuv2LX0/HN0Dxk+yjhnVVuu4AkoBJ/xzKiuOLq+YT/j C9nPprWbDw6j2ev5O4BhEQgfnXdp7ckOOotT3Qhi1nojO7iFpjaZDi2Tc+CMeNDsn0cP PZMpIRdHS0T69fgUXbCfbRdJGHhkZWCArK3CJYxYuDto/68qJlcu5Kx/kCNVTY0YSDBR MZXw== X-Gm-Message-State: AOJu0Yxy4LkIplCzPSjBftpAnUCjVWSdsC9Ow+EE0BD6Nr6EOfFJ8Ynq eFB5YG3yEM4ZDl9bjhyVHtZ11/JwhlDa7sU3g84M6IB4/OZO7zDXVEJmygw= X-Google-Smtp-Source: AGHT+IGeIahQO+5EXkINub34pWqQipO2ln174AT0N4jWQDVQI4z+JyqyJpD2HTQPKkDeqbTlv86loqeWjb+xavtTPgw= X-Received: by 2002:a05:6a21:3982:b0:19a:999c:6653 with SMTP id ad2-20020a056a21398200b0019a999c6653mr12489482pzc.2.1705323923354; Mon, 15 Jan 2024 05:05:23 -0800 (PST) MIME-Version: 1.0 References: <20231120120649.672893-1-maxim.kuvyrkov@linaro.org> <20231122111415.815147-7-maxim.kuvyrkov@linaro.org> In-Reply-To: <20231122111415.815147-7-maxim.kuvyrkov@linaro.org> From: Maxim Kuvyrkov Date: Mon, 15 Jan 2024 17:05:11 +0400 Message-ID: Subject: Re: [PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts To: gcc-patches@gcc.gnu.org Cc: Bernd Schmidt , Vladimir Makarov , Jeff Law , Alexander Monakov , Richard Guenther Content-Type: multipart/alternative; boundary="000000000000add51d060efbaa3a" X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000add51d060efbaa3a Content-Type: text/plain; charset="UTF-8" Dear scheduler maintainers, Gentle ping. This is a trivial cleanup. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. > (free_deps): Remove useless code. > --- > gcc/sched-deps.cc | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc > index 2a87158ba4b..e0d3c97d935 100644 > --- a/gcc/sched-deps.cc > +++ b/gcc/sched-deps.cc > @@ -3927,10 +3927,9 @@ init_deps (class deps_desc *deps, bool > lazy_reg_last) > int max_reg = (reload_completed ? FIRST_PSEUDO_REGISTER : max_reg_num > ()); > > deps->max_reg = max_reg; > - if (lazy_reg_last) > - deps->reg_last = NULL; > - else > - deps->reg_last = XCNEWVEC (struct deps_reg, max_reg); > + deps->reg_last = NULL; > + if (!lazy_reg_last) > + init_deps_reg_last (deps); > INIT_REG_SET (&deps->reg_last_in_use); > > deps->pending_read_insns = 0; > @@ -3961,9 +3960,7 @@ init_deps (class deps_desc *deps, bool lazy_reg_last) > void > init_deps_reg_last (class deps_desc *deps) > { > - gcc_assert (deps && deps->max_reg > 0); > - gcc_assert (deps->reg_last == NULL); > - > + gcc_assert (deps && deps->max_reg > 0 && deps->reg_last == NULL); > deps->reg_last = XCNEWVEC (struct deps_reg, deps->max_reg); > } > > @@ -4013,8 +4010,6 @@ free_deps (class deps_desc *deps) > it at all. */ > free (deps->reg_last); > deps->reg_last = NULL; > - > - deps = NULL; > } > > /* Remove INSN from dependence contexts DEPS. */ > -- > 2.34.1 > > -- Maxim Kuvyrkov www.linaro.org --000000000000add51d060efbaa3a--