From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 44A683858407 for ; Mon, 15 Jan 2024 13:04:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44A683858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44A683858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705323883; cv=none; b=wu8jT+Nxj8rIwsZ7N4/6xaKevu3kr6X4NnEBTmngq/sh0VgumGDMn5W6tAI2cqzrR06xwZK/db9RTHVBGnBCJM3F3jkDR9TRrFQIF7Bg3SN154GI4+Uwb3H1mc+M5d5b/UC6g1BAXMj2j8ejKJztOsJ/8+3eG09URKp7p4IFEws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705323883; c=relaxed/simple; bh=m7fK3OkEC1wnCVsR0iJOxbZbty/gknqACrgdfd6lnLU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=XsVs4Jn2MjRzeUp7jP+K2YlGoAQQe3PJ/Wy6BYn1lrZciHujkLhstOufHp9fyGBsZuZ5zA3j4jE/UDtIqauh1Arj7jz1R13e39jXIBIzO6rsXmxT5eLVyO0L0H/5rkd6Gm3Qrpkk05bYKBQp73NpoZ0eUuRS6p5e9FoK2MQVLo8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-28e42da87f7so379827a91.1 for ; Mon, 15 Jan 2024 05:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705323871; x=1705928671; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=C5aepxSfY7HoRKmPTCoxtqok45A1Khuq9eZOnGj10+I=; b=hbVBnvzXeOcJtMHIs9vva8xJ4rdoPWERqvY88QpgRaXfvvv6Su8I9DKX2ALSW/uJZ6 XeqpDTSY55TCaR3FGi2j1ZtQsU5KdGMu5qnNv+ewW9TonT0GvTi7Lk0t3Hd7xjsTBBxz B5I/x8ioHx0/5zUXpL49cIGFhEtDeUdMo4Vzwwg7VOXGkXbiSWLj3gJCYIcUcGneKrBS v4zWdOy+9oClJuvvEMwbeuJNT63hUJozPLJxLv4wmb94d8hPc/tKMyWGwtOyNeDOvmAp IRJ+eXa3oEjmgWpKY4S3johNJMoYRG8MSMMb9PQmJ9UwJWlI6ONEGZIJJkaC+7MOzjIs aKRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705323871; x=1705928671; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C5aepxSfY7HoRKmPTCoxtqok45A1Khuq9eZOnGj10+I=; b=ai1O3IvDfYlHA5ixH8Lt0dfPOUh9AZCvHRpsUO2XKx0kEWg3d9YBE5AzEuVDEAf9kB 6WQ4lyYiisSb7Ue21TWuLG8LcjWh55s+iQA6pBWLaey07FIMXhW80IGEW/6xEoqMDr1k aNMQVgHR5hurAZNN7tInLKbT52HF7AwWCo+CmHzSFZR7+JgTHFonkdkq14ZTDwIvpxgZ /HJuvjkZl4YC1zD2o2PylzfKFzy8FZ6uqBrB+RSwFBexxg1y3RYJy+Y67Gbc8mnywHoT ttwPLxrbvgsEZma9qVkpXRt1hEOrUzqHRwOlPgMMoBkoeAipYaTYqSzHMtHv5eRVxHXP 8Jkw== X-Gm-Message-State: AOJu0YzcZF2V1S+YO72HdggLMV0+ToKUSTjwO/ylrDONzYOowEbNsKX9 EO7a/6ThcGNaRXbNYbs16uEswFo/aXqDNDr+As3vdm3apaD2k0p46vlzWN4= X-Google-Smtp-Source: AGHT+IE8eRQQzp1XmAEGw60pABJNgcuH5Sn0CsXqzAgyzESms7FYX8C++uzzJDuNVQVFSaOSGrtCfb6TYS4LFrknEc4= X-Received: by 2002:a17:90b:1d10:b0:28d:c024:be86 with SMTP id on16-20020a17090b1d1000b0028dc024be86mr10454856pjb.2.1705323871328; Mon, 15 Jan 2024 05:04:31 -0800 (PST) MIME-Version: 1.0 References: <20231120120649.672893-1-maxim.kuvyrkov@linaro.org> <20231122111415.815147-6-maxim.kuvyrkov@linaro.org> In-Reply-To: <20231122111415.815147-6-maxim.kuvyrkov@linaro.org> From: Maxim Kuvyrkov Date: Mon, 15 Jan 2024 17:04:19 +0400 Message-ID: Subject: Re: [PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis To: gcc-patches@gcc.gnu.org Cc: Bernd Schmidt , Vladimir Makarov , Jeff Law , Alexander Monakov , Richard Guenther Content-Type: multipart/alternative; boundary="00000000000093efbc060efba787" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000093efbc060efba787 Content-Type: text/plain; charset="UTF-8" Dear scheduler maintainers, Gentle ping. This is a trivial patch, which makes debugging sched-deps.cc slightly more enjoyable. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (sd_add_dep, find_inc): Add logging about > dependency creation. > --- > gcc/sched-deps.cc | 30 ++++++++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc > index 4d357079a7a..2a87158ba4b 100644 > --- a/gcc/sched-deps.cc > +++ b/gcc/sched-deps.cc > @@ -1342,6 +1342,13 @@ sd_add_dep (dep_t dep, bool resolved_p) > in the bitmap caches of dependency information. */ > if (true_dependency_cache != NULL) > set_dependency_caches (dep); > + > + if (sched_verbose >= 9) > + { > + fprintf (sched_dump, "created dependency "); > + dump_dep (sched_dump, dep, 1); > + fprintf (sched_dump, "\n"); > + } > } > > /* Add or update backward dependence between INSN and ELEM > @@ -4879,18 +4886,33 @@ find_inc (struct mem_inc_info *mii, bool backwards) > we create. */ > gcc_assert (mii->inc_insn == inc_cand); > > + int n_deps_created = 0; > if (backwards) > { > FOR_EACH_DEP (mii->inc_insn, SD_LIST_BACK, sd_it, dep) > - add_dependence_1 (mii->mem_insn, DEP_PRO (dep), > - REG_DEP_TRUE); > + { > + add_dependence_1 (mii->mem_insn, DEP_PRO (dep), > + REG_DEP_TRUE); > + ++n_deps_created; > + } > } > else > { > FOR_EACH_DEP (mii->inc_insn, SD_LIST_FORW, sd_it, dep) > - add_dependence_1 (DEP_CON (dep), mii->mem_insn, > - REG_DEP_ANTI); > + { > + add_dependence_1 (DEP_CON (dep), mii->mem_insn, > + REG_DEP_ANTI); > + ++n_deps_created; > + } > } > + if (sched_verbose >= 6) > + fprintf (sched_dump, > + "created %d deps for mem_insn %d due to " > + "inc_insn %d %s deps\n", > + n_deps_created, INSN_UID (mii->mem_insn), > + INSN_UID (mii->inc_insn), > + backwards ? "backward" : "forward"); > + > return true; > } > next: > -- > 2.34.1 > > -- Maxim Kuvyrkov www.linaro.org --00000000000093efbc060efba787--