From: Yvan Roux <yvan.roux@linaro.org>
To: Christian Bruel <christian.bruel@st.com>
Cc: "Bin.Cheng" <amker.cheng@gmail.com>,
Uros Bizjak <ubizjak@gmail.com>,
Richard Henderson <rth@redhat.com>, Jan Hubicka <hubicka@ucw.cz>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook
Date: Tue, 05 May 2015 09:11:00 -0000 [thread overview]
Message-ID: <CAD57uCcVsD--Xtk7qwnMrGJq4DR4-RdtskU13kxJvWYqH5zn4w@mail.gmail.com> (raw)
In-Reply-To: <55473BF4.3010603@st.com>
Hi Christian,
On 4 May 2015 at 11:29, Christian Bruel <christian.bruel@st.com> wrote:
>
>> Hi Christian,
>> I noticed case gcc.dg/ipa/iinline-attr.c failed on aarch64. The
>> original patch is x86 specific, while the case is added as general
>> one. Could you please have a look at this?
>>
>> FAIL: gcc.dg/ipa/iinline-attr.c scan-ipa-dump inline
>> "hooray[^\\n]*inline copy in test"
>>
>
> that is the same latent bug for aarch64: alignment flags are not
> propagated with attribute optimize ("O2").
>
> testing attached patch
The patch looks good to me, maybe you can just fix the original typo
on "optimizing" in the comments while moving the code. I've
bootstrapped and regtested it on aarch64-linux-gnu with the same
target testcase you added on i386 (as we discussed offline) and
everything is ok (gcc.dg/ipa/iinline-attr.c now PASS). Notice that I
can't approve your patch.
Cheers,
Yvan
next prev parent reply other threads:[~2015-05-05 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 13:21 Christian Bruel
2015-04-27 12:01 ` Uros Bizjak
2015-04-30 8:38 ` Bin.Cheng
2015-04-30 8:43 ` Christian Bruel
2015-05-04 9:29 ` Christian Bruel
2015-05-05 9:11 ` Yvan Roux [this message]
2015-05-05 9:45 ` Christian Bruel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD57uCcVsD--Xtk7qwnMrGJq4DR4-RdtskU13kxJvWYqH5zn4w@mail.gmail.com \
--to=yvan.roux@linaro.org \
--cc=amker.cheng@gmail.com \
--cc=christian.bruel@st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=rth@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).