* [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
@ 2014-08-27 8:04 Yvan Roux
2014-08-27 9:25 ` Richard Earnshaw
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 8:04 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
Hi,
as reported in PR62248 there is a typo in gcc/config.gcc where
--with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
config.gcc). Here is the patch to fix it.
Thanks,
Yvan
2014-08-27 Yvan Roux <yvan.roux@linaro.org>
* config.gcc: Fix fp-armv8 option for arm*-*-* targets.
[-- Attachment #2: pr62248.diff --]
[-- Type: text/plain, Size: 478 bytes --]
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 6862c127..3f68e3e 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -3528,7 +3528,7 @@ case "${target}" in
| vfp | vfp3 | vfpv3 \
| vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
| vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
- | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
+ | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
| crypto-neon-fp-armv8)
# OK
;;
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 8:04 [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8 Yvan Roux
@ 2014-08-27 9:25 ` Richard Earnshaw
2014-08-27 10:35 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Richard Earnshaw @ 2014-08-27 9:25 UTC (permalink / raw)
To: Yvan Roux, gcc-patches
On 27/08/14 09:04, Yvan Roux wrote:
> Hi,
>
> as reported in PR62248 there is a typo in gcc/config.gcc where
> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
> config.gcc). Here is the patch to fix it.
>
> Thanks,
> Yvan
>
> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>
> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>
>
> pr62248.diff
>
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 6862c127..3f68e3e 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -3528,7 +3528,7 @@ case "${target}" in
> | vfp | vfp3 | vfpv3 \
> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
> | crypto-neon-fp-armv8)
> # OK
> ;;
>
Ok; but better still would be to change this to use the official list in
arm-fpus.def (like we do for CPU names).
R.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 9:25 ` Richard Earnshaw
@ 2014-08-27 10:35 ` Yvan Roux
2014-08-27 11:10 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 10:35 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gcc-patches
On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
> On 27/08/14 09:04, Yvan Roux wrote:
>> Hi,
>>
>> as reported in PR62248 there is a typo in gcc/config.gcc where
>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>> config.gcc). Here is the patch to fix it.
>>
>> Thanks,
>> Yvan
>>
>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>
>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>
>>
>> pr62248.diff
>>
>>
>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>> index 6862c127..3f68e3e 100644
>> --- a/gcc/config.gcc
>> +++ b/gcc/config.gcc
>> @@ -3528,7 +3528,7 @@ case "${target}" in
>> | vfp | vfp3 | vfpv3 \
>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>> | crypto-neon-fp-armv8)
>> # OK
>> ;;
>>
>
> Ok; but better still would be to change this to use the official list in
> arm-fpus.def (like we do for CPU names).
Yes indeed, I'll do it that way.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 10:35 ` Yvan Roux
@ 2014-08-27 11:10 ` Yvan Roux
2014-08-27 11:35 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 11:10 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
Here is the patch that uses the arm-fpus.def list.
Thanks
Yvan
2014-08-27 Yvan Roux <yvan.roux@linaro.org>
* config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
On 27 August 2014 12:35, Yvan Roux <yvan.roux@linaro.org> wrote:
> On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
>> On 27/08/14 09:04, Yvan Roux wrote:
>>> Hi,
>>>
>>> as reported in PR62248 there is a typo in gcc/config.gcc where
>>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>>> config.gcc). Here is the patch to fix it.
>>>
>>> Thanks,
>>> Yvan
>>>
>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>
>>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>>
>>>
>>> pr62248.diff
>>>
>>>
>>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>>> index 6862c127..3f68e3e 100644
>>> --- a/gcc/config.gcc
>>> +++ b/gcc/config.gcc
>>> @@ -3528,7 +3528,7 @@ case "${target}" in
>>> | vfp | vfp3 | vfpv3 \
>>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>>> | crypto-neon-fp-armv8)
>>> # OK
>>> ;;
>>>
>>
>> Ok; but better still would be to change this to use the official list in
>> arm-fpus.def (like we do for CPU names).
>
> Yes indeed, I'll do it that way.
[-- Attachment #2: pr62248.diff --]
[-- Type: text/plain, Size: 895 bytes --]
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 6862c127..7434a08 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -3523,20 +3523,17 @@ case "${target}" in
;;
esac
- case "$with_fpu" in
- "" \
- | vfp | vfp3 | vfpv3 \
- | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
- | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
- | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
- | crypto-neon-fp-armv8)
- # OK
- ;;
- *)
- echo "Unknown fpu used in --with-fpu=$with_fpu" 2>&1
- exit 1
- ;;
- esac
+ # see if it matches any of the entries in arm-fpus.def
+ if [ x"$with_fpu" = x ] \
+ || grep "^ARM_FPU(\"$with_fpu\"," \
+ ${srcdir}/config/arm/arm-fpus.def \
+ > /dev/null; then
+ # OK
+ true
+ else
+ echo "Unknown fpu used in --with-fpu=$with_fpu" 1>&2
+ exit 1
+ fi
case "$with_abi" in
"" \
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 11:10 ` Yvan Roux
@ 2014-08-27 11:35 ` Yvan Roux
2014-08-27 12:26 ` Richard Earnshaw
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 11:35 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gcc-patches
with the PR in the ChangeLog:
2014-08-27 Yvan Roux <yvan.roux@linaro.org>
PR other/62248
* config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
On 27 August 2014 13:10, Yvan Roux <yvan.roux@linaro.org> wrote:
> Here is the patch that uses the arm-fpus.def list.
>
> Thanks
> Yvan
>
> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>
> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>
> On 27 August 2014 12:35, Yvan Roux <yvan.roux@linaro.org> wrote:
>> On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
>>> On 27/08/14 09:04, Yvan Roux wrote:
>>>> Hi,
>>>>
>>>> as reported in PR62248 there is a typo in gcc/config.gcc where
>>>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>>>> config.gcc). Here is the patch to fix it.
>>>>
>>>> Thanks,
>>>> Yvan
>>>>
>>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>>
>>>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>>>
>>>>
>>>> pr62248.diff
>>>>
>>>>
>>>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>>>> index 6862c127..3f68e3e 100644
>>>> --- a/gcc/config.gcc
>>>> +++ b/gcc/config.gcc
>>>> @@ -3528,7 +3528,7 @@ case "${target}" in
>>>> | vfp | vfp3 | vfpv3 \
>>>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>>>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>>>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>>>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>>>> | crypto-neon-fp-armv8)
>>>> # OK
>>>> ;;
>>>>
>>>
>>> Ok; but better still would be to change this to use the official list in
>>> arm-fpus.def (like we do for CPU names).
>>
>> Yes indeed, I'll do it that way.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 11:35 ` Yvan Roux
@ 2014-08-27 12:26 ` Richard Earnshaw
2014-08-27 14:22 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Richard Earnshaw @ 2014-08-27 12:26 UTC (permalink / raw)
To: Yvan Roux; +Cc: gcc-patches
On 27/08/14 12:35, Yvan Roux wrote:
> with the PR in the ChangeLog:
>
> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>
> PR other/62248
> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>
>
OK, thanks.
R.
> On 27 August 2014 13:10, Yvan Roux <yvan.roux@linaro.org> wrote:
>> Here is the patch that uses the arm-fpus.def list.
>>
>> Thanks
>> Yvan
>>
>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>
>> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>>
>> On 27 August 2014 12:35, Yvan Roux <yvan.roux@linaro.org> wrote:
>>> On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
>>>> On 27/08/14 09:04, Yvan Roux wrote:
>>>>> Hi,
>>>>>
>>>>> as reported in PR62248 there is a typo in gcc/config.gcc where
>>>>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>>>>> config.gcc). Here is the patch to fix it.
>>>>>
>>>>> Thanks,
>>>>> Yvan
>>>>>
>>>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>>>
>>>>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>>>>
>>>>>
>>>>> pr62248.diff
>>>>>
>>>>>
>>>>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>>>>> index 6862c127..3f68e3e 100644
>>>>> --- a/gcc/config.gcc
>>>>> +++ b/gcc/config.gcc
>>>>> @@ -3528,7 +3528,7 @@ case "${target}" in
>>>>> | vfp | vfp3 | vfpv3 \
>>>>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>>>>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>>>>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>>>>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>>>>> | crypto-neon-fp-armv8)
>>>>> # OK
>>>>> ;;
>>>>>
>>>>
>>>> Ok; but better still would be to change this to use the official list in
>>>> arm-fpus.def (like we do for CPU names).
>>>
>>> Yes indeed, I'll do it that way.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 12:26 ` Richard Earnshaw
@ 2014-08-27 14:22 ` Yvan Roux
2014-08-27 16:51 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 14:22 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gcc-patches
Committed on trunk at r214573, and I'll backport it on 4.9 branch.
On 27 August 2014 14:26, Richard Earnshaw <rearnsha@arm.com> wrote:
> On 27/08/14 12:35, Yvan Roux wrote:
>> with the PR in the ChangeLog:
>>
>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>
>> PR other/62248
>> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>>
>>
>
> OK, thanks.
>
> R.
>
>> On 27 August 2014 13:10, Yvan Roux <yvan.roux@linaro.org> wrote:
>>> Here is the patch that uses the arm-fpus.def list.
>>>
>>> Thanks
>>> Yvan
>>>
>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>
>>> * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def.
>>>
>>> On 27 August 2014 12:35, Yvan Roux <yvan.roux@linaro.org> wrote:
>>>> On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote:
>>>>> On 27/08/14 09:04, Yvan Roux wrote:
>>>>>> Hi,
>>>>>>
>>>>>> as reported in PR62248 there is a typo in gcc/config.gcc where
>>>>>> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in
>>>>>> config.gcc). Here is the patch to fix it.
>>>>>>
>>>>>> Thanks,
>>>>>> Yvan
>>>>>>
>>>>>> 2014-08-27 Yvan Roux <yvan.roux@linaro.org>
>>>>>>
>>>>>> * config.gcc: Fix fp-armv8 option for arm*-*-* targets.
>>>>>>
>>>>>>
>>>>>> pr62248.diff
>>>>>>
>>>>>>
>>>>>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>>>>>> index 6862c127..3f68e3e 100644
>>>>>> --- a/gcc/config.gcc
>>>>>> +++ b/gcc/config.gcc
>>>>>> @@ -3528,7 +3528,7 @@ case "${target}" in
>>>>>> | vfp | vfp3 | vfpv3 \
>>>>>> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \
>>>>>> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \
>>>>>> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \
>>>>>> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \
>>>>>> | crypto-neon-fp-armv8)
>>>>>> # OK
>>>>>> ;;
>>>>>>
>>>>>
>>>>> Ok; but better still would be to change this to use the official list in
>>>>> arm-fpus.def (like we do for CPU names).
>>>>
>>>> Yes indeed, I'll do it that way.
>>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 14:22 ` Yvan Roux
@ 2014-08-27 16:51 ` Bernhard Reutner-Fischer
2014-08-27 17:07 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Bernhard Reutner-Fischer @ 2014-08-27 16:51 UTC (permalink / raw)
To: Yvan Roux, Richard Earnshaw; +Cc: gcc-patches
On 27 August 2014 16:22:28 CEST, Yvan Roux <yvan.roux@linaro.org> wrote:
>Committed on trunk at r214573, and I'll backport it on 4.9 branch.
s/true/:/
?
Thanks,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 16:51 ` Bernhard Reutner-Fischer
@ 2014-08-27 17:07 ` Yvan Roux
2014-08-27 17:13 ` Yvan Roux
0 siblings, 1 reply; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 17:07 UTC (permalink / raw)
To: Bernhard Reutner-Fischer; +Cc: Richard Earnshaw, gcc-patches
"true" seems to be used that way for aarch64*-*-* and arm*-*-* is it
preferable to change it to ";" for all occurrences ?
Thanks,
Yvan
On 27 August 2014 18:51, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> On 27 August 2014 16:22:28 CEST, Yvan Roux <yvan.roux@linaro.org> wrote:
>>Committed on trunk at r214573, and I'll backport it on 4.9 branch.
>
> s/true/:/
>
> ?
> Thanks,
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8
2014-08-27 17:07 ` Yvan Roux
@ 2014-08-27 17:13 ` Yvan Roux
0 siblings, 0 replies; 10+ messages in thread
From: Yvan Roux @ 2014-08-27 17:13 UTC (permalink / raw)
To: Bernhard Reutner-Fischer; +Cc: Richard Earnshaw, gcc-patches
On 27 August 2014 19:07, Yvan Roux <yvan.roux@linaro.org> wrote:
> "true" seems to be used that way for aarch64*-*-* and arm*-*-* is it
> preferable to change it to ";" for all occurrences ?
sorry for the typo, I meant colon and not semicolon.
> Thanks,
> Yvan
>
> On 27 August 2014 18:51, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>> On 27 August 2014 16:22:28 CEST, Yvan Roux <yvan.roux@linaro.org> wrote:
>>>Committed on trunk at r214573, and I'll backport it on 4.9 branch.
>>
>> s/true/:/
>>
>> ?
>> Thanks,
>>
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-27 17:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-27 8:04 [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8 Yvan Roux
2014-08-27 9:25 ` Richard Earnshaw
2014-08-27 10:35 ` Yvan Roux
2014-08-27 11:10 ` Yvan Roux
2014-08-27 11:35 ` Yvan Roux
2014-08-27 12:26 ` Richard Earnshaw
2014-08-27 14:22 ` Yvan Roux
2014-08-27 16:51 ` Bernhard Reutner-Fischer
2014-08-27 17:07 ` Yvan Roux
2014-08-27 17:13 ` Yvan Roux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).