public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Yvan Roux <yvan.roux@linaro.org>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>, Paolo Bonzini <bonzini@gnu.org>
Subject: Re: [Libgomp, Fortran] Fix canadian cross build
Date: Fri, 18 Aug 2017 09:31:00 -0000	[thread overview]
Message-ID: <CAD57uCdged-aSE9aDsE7Pite52USkOhsqOkUEQNB37Sjfa1NYQ@mail.gmail.com> (raw)
In-Reply-To: <CAD57uCcKHXJ=FN0P2VvtE=GDwmgQAoBVbWcXpe9b6pxHQKSKNg@mail.gmail.com>

On 4 August 2017 at 15:52, Yvan Roux <yvan.roux@linaro.org> wrote:
> On 11 July 2017 at 12:25, Yvan Roux <yvan.roux@linaro.org> wrote:
>> On 3 July 2017 at 11:21, Yvan Roux <yvan.roux@linaro.org> wrote:
>>> On 23 June 2017 at 15:44, Yvan Roux <yvan.roux@linaro.org> wrote:
>>>> Hello,
>>>>
>>>> Fortran parts of libgomp (omp_lib.mod, openacc.mod, etc...) are
>>>> missing in a canadian cross build, at least when target gfortran
>>>> compiler comes from PATH and not from GFORTRAN_FOR_TARGET.
>>>>
>>>> Back in 2010, executability test of GFORTRAN was added to fix libgomp
>>>> build on cygwin, but when the executable doesn't contain the path,
>>>> "test -x" fails and part of the library are not built.
>>>>
>>>> This patch fixes the issue by using M4 macro AC_PATH_PROG (which
>>>> returns the absolute name) instead of AC_CHECK_PROG in the function
>>>> defined in config/acx.m4: NCN_STRICT_CHECK_TARGET_TOOLS.  I renamed it
>>>> into NCN_STRICT_PATH_TARGET_TOOLS to keep the semantic used in M4.
>>>>
>>>> Tested by building cross and candian cross toolchain (host:
>>>> i686-w64-mingw32) for arm-linux-gnueabihf with issue and with a
>>>> complete libgomp.
>>>>
>>>> ok for trunk ?
>>>
>>> ping?
>>
>> ping?
>
> ping

ping

https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01784.html

>>>
>>>> Thanks
>>>> Yvan
>>>>
>>>> config/ChangeLog
>>>> 2017-06-23  Yvan Roux  <yvan.roux@linaro.org>
>>>>
>>>>         * acx.m4 (NCN_STRICT_CHECK_TARGET_TOOLS): Renamed to ...
>>>>         (NCN_STRICT_PATH_TARGET_TOOLS): ... this.  It reflects the replacement
>>>>         of AC_CHECK_PROG by AC_PATH_PROG to get the absolute name of the
>>>>         program.
>>>>         (ACX_CHECK_INSTALLED_TARGET_TOOL): Use renamed function.
>>>>
>>>> ChangeLog
>>>> 2017-06-23  Yvan Roux  <yvan.roux@linaro.org>
>>>>
>>>>         * configure.ac: Use NCN_STRICT_PATH_TARGET_TOOLS instead of
>>>>         NCN_STRICT_CHECK_TARGET_TOOLS.
>>>>         * configure: Regenerate.

  reply	other threads:[~2017-08-18  8:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 13:44 Yvan Roux
2017-07-03  9:21 ` Yvan Roux
2017-07-11 10:25   ` Yvan Roux
2017-08-04 13:52     ` Yvan Roux
2017-08-18  9:31       ` Yvan Roux [this message]
2017-09-05  8:58         ` Yvan Roux
2017-09-05 10:04           ` Jakub Jelinek
2017-10-05 10:56             ` Yvan Roux
2017-10-05 11:39               ` Petr Ovtchenkov
2018-02-01 11:33                 ` Yvan Roux
2018-05-23  9:07 ` Maxim Kuvyrkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD57uCdged-aSE9aDsE7Pite52USkOhsqOkUEQNB37Sjfa1NYQ@mail.gmail.com \
    --to=yvan.roux@linaro.org \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).