From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49910 invoked by alias); 14 Apr 2015 08:08:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49900 invoked by uid 89); 14 Apr 2015 08:08:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 14 Apr 2015 08:08:28 +0000 Received: by wiun10 with SMTP id n10so11937789wiu.1 for ; Tue, 14 Apr 2015 01:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nwbU5dzDXbPJcH8QdyE40EZmoGSA59Ar4XsqyjSbmyU=; b=IMhV68T2Z7HYM7Gs/YT9GginTmk7REGmW/CfKFfuF1Sje/notm9H6skE7GtoktlzQ9 0Jy7vEGLsRG2OytK1AEysWUNaVxpxc9GbJmC74TpDxQSmx+dQkPa4XcLfxJB02MA9FeA PbmFBkYsxa2SIJQy73SVyV9PzRVV2I4eWWRHguJwYu2c6aFvMkF3Huus5bOCvtaCGzRw /bzy1nE0SzMgDiVshMEOM8pCTmPEWO4hyVuoYUlJXSKbcUpB37GPyShhtXwMhNEGwFZ3 Bp1QVCU70HxmDKDQ402GS/aovxyuHfbZ+G23i2EJPjGmpeyI+kErjlZPUoyOBJY96r41 AWZA== X-Gm-Message-State: ALoCoQm7qD4sSNOeN5ztKeA5f1AeIWrz8a/5pWlOAx1lx1qW+SrBnB9lixMSy7jwHUPvcuAmgY9Y MIME-Version: 1.0 X-Received: by 10.180.91.77 with SMTP id cc13mr29430287wib.88.1428998905104; Tue, 14 Apr 2015 01:08:25 -0700 (PDT) Received: by 10.28.4.204 with HTTP; Tue, 14 Apr 2015 01:08:24 -0700 (PDT) In-Reply-To: <5527FCAC.3090205@redhat.com> References: <5527FCAC.3090205@redhat.com> Date: Tue, 14 Apr 2015 08:08:00 -0000 Message-ID: Subject: Re: patch for PR65729 From: Yvan Roux To: Vladimir Makarov , Jakub Jelinek Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=f46d043be0aa2046280513aabcaa X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00632.txt.bz2 --f46d043be0aa2046280513aabcaa Content-Type: text/plain; charset=UTF-8 Content-length: 1606 Hi, here is the patch that restore the assertion and swap its arguments as discussed in the PR. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65729 Bootstrapped and regtested on x86_64, cross built and regtested on i686, aarch64, arm and armeb. Is it ok for trunk (maybe after 5.1 is released) ? Thanks, Yvan gcc/ 2015-04-13 Yvan Roux PR target/65729 * lra-constraints.c (prohibited_class_reg_set_mode_p): Restore and fix the assertion. gcc/testsuite/ 2015-04-13 Yvan Roux PR target/65729 * gcc.target/arm/pr65729.c: New test. On 10 April 2015 at 18:39, Vladimir Makarov wrote: > I've committed the following patch for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65729 > > The assert is definitely wrong. We will work for the right one for > GCC-5.1. > > Committed as rev. 221975. > > 2015-04-10 Vladimir Makarov > > PR target/65729 > * lra-constraints.c (prohibited_class_reg_set_mode_p): Comment the > assert. > > Index: lra-constraints.c > =================================================================== > --- lra-constraints.c (revision 221949) > +++ lra-constraints.c (working copy) > @@ -1656,7 +1656,8 @@ > { > HARD_REG_SET temp; > > - lra_assert (hard_reg_set_subset_p (set, reg_class_contents[rclass])); > + // ??? Is this assert right > + // lra_assert (hard_reg_set_subset_p (set, reg_class_contents[rclass])); > COPY_HARD_REG_SET (temp, set); > AND_COMPL_HARD_REG_SET (temp, lra_no_alloc_regs); > return (hard_reg_set_subset_p > --f46d043be0aa2046280513aabcaa Content-Type: text/plain; charset=US-ASCII; name="pr65729.diff" Content-Disposition: attachment; filename="pr65729.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i8h101bq0 Content-length: 1294 ZGlmZiAtLWdpdCBhL2djYy9scmEtY29uc3RyYWludHMuYyBiL2djYy9scmEt Y29uc3RyYWludHMuYwppbmRleCA3MzUzZTdjLi5jNTFhMjViIDEwMDY0NAot LS0gYS9nY2MvbHJhLWNvbnN0cmFpbnRzLmMKKysrIGIvZ2NjL2xyYS1jb25z dHJhaW50cy5jCkBAIC0xNjU2LDggKzE2NTYsNyBAQCBwcm9oaWJpdGVkX2Ns YXNzX3JlZ19zZXRfbW9kZV9wIChlbnVtIHJlZ19jbGFzcyByY2xhc3MsCiB7 CiAgIEhBUkRfUkVHX1NFVCB0ZW1wOwogICAKLSAgLy8gPz8/IElzIHRoaXMg YXNzZXJ0IHJpZ2h0Ci0gIC8vIGxyYV9hc3NlcnQgKGhhcmRfcmVnX3NldF9z dWJzZXRfcCAoc2V0LCByZWdfY2xhc3NfY29udGVudHNbcmNsYXNzXSkpOwor ICBscmFfYXNzZXJ0IChoYXJkX3JlZ19zZXRfc3Vic2V0X3AgKHJlZ19jbGFz c19jb250ZW50c1tyY2xhc3NdLHNldCkpOwogICBDT1BZX0hBUkRfUkVHX1NF VCAodGVtcCwgc2V0KTsKICAgQU5EX0NPTVBMX0hBUkRfUkVHX1NFVCAodGVt cCwgbHJhX25vX2FsbG9jX3JlZ3MpOwogICByZXR1cm4gKGhhcmRfcmVnX3Nl dF9zdWJzZXRfcApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFy Z2V0L2FybS9wcjY1NzI5LmMgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQv YXJtL3ByNjU3MjkuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi4wZDdlM2MxCi0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0 ZS9nY2MudGFyZ2V0L2FybS9wcjY1NzI5LmMKQEAgLTAsMCArMSw5IEBACisv KiB7IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBkZy1vcHRpb25zICItTzIg LW1hcmNoPWFybXY3LWEgLW1mbG9hdC1hYmk9aGFyZCAtbWZwdT12ZnB2My1k MTYiIH0gKi8KKworaW50IGZvbyAodm9pZCkKK3sKKyAgZG91YmxlIHggPSAw LjA7CisgIGFzbSB2b2xhdGlsZSAoIiIgOiAiK2d3IiAoeCkpOworICByZXR1 cm4geDsKK30K --f46d043be0aa2046280513aabcaa--