From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10300 invoked by alias); 15 Apr 2015 12:51:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10291 invoked by uid 89); 15 Apr 2015 12:51:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Apr 2015 12:51:52 +0000 Received: by wiax7 with SMTP id x7so111352945wia.0 for ; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SYShRmtzQSYEjuW9IBwUSV1MgQz2c+1KjIrlNVve49s=; b=aeLicrq2qTaG5S4nxJOuqK0KFRnnAK3qlOwLC4+dXQgoM160qA/OpAuhUDTDp8rtWD YuCNcMHA/HNKE1anC9cCNvVqOfbki/cRLHtmrn8sJFT+ePzhKJuUozVSCRPoQFpRZx8a Bj6MKooK+GFxqVYC/yWs2MmTXbWlJIR1PTzPIBvDIIy9uu6RXbCxNWzwobftGr3XUCg3 uIj42J/PsEzZ4LDSlPecFOSX9ZzgGfchGWex7+XvJNgP+fjzAMDSqYncwQ4hclpGiCYD xJesetOBPDnh24bw6eEtMx9g3d6T65nc8gP4pc9oKOQLyz8wIieMl5Ql5/Tq7jxVlJyE Icmg== X-Gm-Message-State: ALoCoQln22/2eNpSLAXJomk7PKJxeb26l3dbGxRIeOHsACvga/2B4ZLQmvsH2MKzPyuN7AH8ViU6 MIME-Version: 1.0 X-Received: by 10.195.12.48 with SMTP id en16mr34688850wjd.21.1429102309653; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) Received: by 10.28.4.204 with HTTP; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) In-Reply-To: <552D3412.6070100@redhat.com> References: <5527FCAC.3090205@redhat.com> <20150414081123.GF1725@tucnak.redhat.com> <552D3412.6070100@redhat.com> Date: Wed, 15 Apr 2015 12:51:00 -0000 Message-ID: Subject: Re: patch for PR65729 From: Yvan Roux To: Vladimir Makarov Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=047d7bf0d6168470c90513c2cf74 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00754.txt.bz2 --047d7bf0d6168470c90513c2cf74 Content-Type: text/plain; charset=UTF-8 Content-length: 1060 Hi, On 14 April 2015 at 17:36, Vladimir Makarov wrote: > On 04/14/2015 04:11 AM, Jakub Jelinek wrote: >> >> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote: >>> >>> --- a/gcc/lra-constraints.c >>> +++ b/gcc/lra-constraints.c >>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class >>> rclass, >>> { >>> HARD_REG_SET temp; >>> - // ??? Is this assert right >>> - // lra_assert (hard_reg_set_subset_p (set, >>> reg_class_contents[rclass])); >>> + lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set)); >> >> Missing space after , >> Otherwise, I'll defer to Vlad for review. >> >> > The patch is ok for me to commit it into the trunk. Thanks, Yvan. The testcase needs the hard float ABI support, and can fail if tested in a way the -march=armv7-a is overridden. This patch patch restrict the test to hard vfp compliant targets. Ok for trunk ? Thanks, Yvan 2015-04-15 Yvan Roux * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets. --047d7bf0d6168470c90513c2cf74 Content-Type: text/plain; charset=US-ASCII; name="pr65729-fixtestcase.diff" Content-Disposition: attachment; filename="pr65729-fixtestcase.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i8iqiegb0 Content-length: 549 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vcHI2 NTcyOS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS9wcjY1NzI5 LmMKaW5kZXggMGQ3ZTNjMS4uODUzODNiMCAxMDA2NDQKLS0tIGEvZ2NjL3Rl c3RzdWl0ZS9nY2MudGFyZ2V0L2FybS9wcjY1NzI5LmMKKysrIGIvZ2NjL3Rl c3RzdWl0ZS9nY2MudGFyZ2V0L2FybS9wcjY1NzI5LmMKQEAgLTEsNCArMSw1 IEBACiAvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBkZy1yZXF1aXJl LWVmZmVjdGl2ZS10YXJnZXQgYXJtX2hhcmRfdmZwX29rIH0gKi8KIC8qIHsg ZGctb3B0aW9ucyAiLU8yIC1tYXJjaD1hcm12Ny1hIC1tZmxvYXQtYWJpPWhh cmQgLW1mcHU9dmZwdjMtZDE2IiB9ICovCiAKIGludCBmb28gKHZvaWQpCg== --047d7bf0d6168470c90513c2cf74--