public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ilya Verbin <iverbin@gmail.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc <gcc-patches@gcc.gnu.org>,
	michael.v.zolotukhin@intel.com, 	jnorris@codesourcery.com,
	Jakub Jelinek <jakub@redhat.com>,
		Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [gomp4] libgomp: plugin for non-shared memory host execution (was: libgomp.c/target-1.c failing in fn2's GOMP_target_update)
Date: Wed, 19 Feb 2014 17:49:00 -0000	[thread overview]
Message-ID: <CADG=Z0E1cHQtzOK1xiarZJRC1uapBfdaiP6o7qxr2q8uGo9ckg@mail.gmail.com> (raw)
In-Reply-To: <87r46zt76g.fsf@schwinge.name>

2014-02-19 20:10 GMT+04:00 Thomas Schwinge <thomas@codesourcery.com>:
> Here is such a libgomp plugin plus the infrastructure for initial support
> of non-shared memory host execution.  Any comments?
>
> Grüße,
>  Thomas

This plugin looks good.

I think the function call in GOMP_target also should be replaced with
a call to plugin:
- fn ((void *) tgt->tgt_start);
+ devicep->device_run_func (fn, (void *) tgt->tgt_start);

Also I have a question (not related with this plugin): How will
libgomp work with multiple devices of the same type?  Probably it
should load the plugin once, query it for the number of available
devices, add received number of descriptors to the devices[] array, an
then pass devicep->id as an argument to all plugin's interfaces.

  -- Ilya

  reply	other threads:[~2014-02-19 17:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zjpehpz4.fsf@schwinge.name>
     [not found] ` <20131108154000.GP27813@tucnak.zalov.cz>
     [not found]   ` <87lhzqs3tv.fsf@kepler.schwinge.homeip.net>
2014-02-19 16:10     ` Thomas Schwinge
2014-02-19 17:49       ` Ilya Verbin [this message]
2014-02-19 18:07         ` Jakub Jelinek
2014-02-20  9:59           ` [gomp4] libgomp: plugin for non-shared memory host execution Thomas Schwinge
2014-02-20 11:09       ` Thomas Schwinge
2015-07-30 12:26       ` Thomas Schwinge
2015-07-30 12:31         ` Jakub Jelinek
2015-07-31 15:40           ` Thomas Schwinge
2015-08-10 16:51             ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADG=Z0E1cHQtzOK1xiarZJRC1uapBfdaiP6o7qxr2q8uGo9ckg@mail.gmail.com' \
    --to=iverbin@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jnorris@codesourcery.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=michael.v.zolotukhin@intel.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).