From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96433 invoked by alias); 4 Sep 2015 21:45:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95769 invoked by uid 89); 4 Sep 2015 21:45:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f50.google.com Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Sep 2015 21:45:38 +0000 Received: by qgt47 with SMTP id 47so26705757qgt.2 for ; Fri, 04 Sep 2015 14:45:36 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.30.138 with SMTP id d10mr8685880qgd.80.1441403136782; Fri, 04 Sep 2015 14:45:36 -0700 (PDT) Received: by 10.55.57.139 with HTTP; Fri, 4 Sep 2015 14:45:36 -0700 (PDT) In-Reply-To: <4481C24E-AB27-4E2B-AEE6-2E813C0925DB@comcast.net> References: <20150901115012.GQ1847@tucnak.redhat.com> <4481C24E-AB27-4E2B-AEE6-2E813C0925DB@comcast.net> Date: Fri, 04 Sep 2015 22:03:00 -0000 Message-ID: Subject: Re: Fix intelmic-mkoffload.c if the temp path contains a '-' From: Ilya Verbin To: Mike Stump Cc: "Hahnfeld, Jonas" , Jakub Jelinek , "gcc-patches@gcc.gnu.org" , Kirill Yukhin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00382.txt.bz2 2015-09-04 22:27 GMT+03:00 Mike Stump : > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas = wrote: >>>>> * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path >>>>> contains a '-=E2=80=98. > > So, out of curiosity, did you test all characters other than null? If - = doesn=E2=80=99t work, there is a good chance that no such test has been don= e, and there is a small hoard of bugs, all the same in there. Good point. Objcopy in bfd/binary.c creates symbol names this way: for (p =3D buf; *p; p++) if (! ISALNUM (*p)) *p =3D '_'; We should do the same in intelmic-mkoffload.c. I will prepare a patch. -- Ilya