From: Ilya Verbin <iverbin@gmail.com>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
Michael Zolotukhin <michael.v.zolotukhin@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [gomp4] Add tables generation
Date: Thu, 03 Apr 2014 17:25:00 -0000 [thread overview]
Message-ID: <CADG=Z0GUi8UDookgwcd0AzDjWDS9pWyqt-c8GRyM3=gjrwg_zQ@mail.gmail.com> (raw)
In-Reply-To: <533D9509.4070800@codesourcery.com>
2014-04-03 21:06 GMT+04:00 Bernd Schmidt <bernds@codesourcery.com>:
> On 04/03/2014 06:53 PM, Ilya Verbin wrote:
>>
>> 2014-04-03 20:13 GMT+04:00 Bernd Schmidt <bernds@codesourcery.com>:
>>>
>>> The patch below should be a better fix, making the references to >
>>> __OPENMP_TARGET__ weak. Does this work for you?
>>
>>
>> Shouldn't we just remove __OPENMP_TARGET__ argument from GOMP_target,
>> since we decided to pass it to GOMP_offload_register?
>
>
> I thought it was used to look up the right function? With shared libraries
> you'd get multiple __OPENMP_TARGET__ tables.
>
>
> Bernd
>
Yes, initially the idea was to use it for look up the right function.
But now each DSO will call GOMP_offload_register, and pass unique
pointer to __OPENMP_TARGET__ (host_table) for this DSO. Then
gomp_register_images_for_device registers all this host tables in the
plugin. And when libgomp calls device_get_table_func, the plugin
returns the joint table for all DSO's.
-- Ilya
next prev parent reply other threads:[~2014-04-03 17:25 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 17:01 Bernd Schmidt
2014-03-20 19:24 ` Jakub Jelinek
2014-03-21 15:21 ` Bernd Schmidt
2014-03-21 15:28 ` Jakub Jelinek
2014-03-21 16:16 ` Bernd Schmidt
2014-04-04 9:33 ` Bernd Schmidt
2014-04-05 15:05 ` Thomas Schwinge
2014-04-05 15:24 ` Bernd Schmidt
2014-04-08 6:03 ` Jakub Jelinek
2014-05-06 15:32 ` Ilya Verbin
2014-05-08 10:11 ` Bernd Schmidt
2014-05-12 20:44 ` Bernd Schmidt
2014-03-27 13:44 ` Ilya Verbin
2014-03-27 13:52 ` Bernd Schmidt
2014-03-27 13:59 ` Bernd Schmidt
2014-03-27 15:12 ` Jakub Jelinek
2014-03-27 16:17 ` Ilya Verbin
2014-03-27 16:23 ` Jakub Jelinek
2014-03-27 18:51 ` Ilya Verbin
2014-04-17 18:44 ` Ilya Verbin
2014-04-25 11:55 ` Ilya Verbin
2014-06-10 13:52 ` Bernd Schmidt
2014-06-10 18:07 ` Ilya Verbin
2014-08-13 16:19 ` Ilya Verbin
2014-08-18 16:08 ` Ilya Verbin
2014-08-18 16:25 ` Bernd Schmidt
2014-08-19 10:41 ` Ilya Verbin
2014-08-19 11:55 ` Bernd Schmidt
2014-08-19 12:26 ` Ilya Verbin
2014-08-19 13:27 ` Ilya Verbin
2014-09-02 17:50 ` Ilya Verbin
2014-09-04 13:08 ` Thomas Schwinge
2014-09-04 13:47 ` Ilya Verbin
2014-09-04 13:54 ` Thomas Schwinge
2014-09-05 15:09 ` Ilya Verbin
2014-09-08 18:46 ` Ilya Verbin
2014-09-03 19:24 ` Thomas Schwinge
2014-04-02 7:34 ` Thomas Schwinge
2014-04-02 8:36 ` Thomas Schwinge
2014-04-03 16:15 ` Bernd Schmidt
2014-04-03 16:53 ` Ilya Verbin
2014-04-03 17:08 ` Bernd Schmidt
2014-04-03 17:25 ` Ilya Verbin [this message]
2014-04-03 17:31 ` Bernd Schmidt
2014-04-03 17:39 ` Ilya Verbin
2014-04-04 5:55 ` Thomas Schwinge
2014-04-04 9:25 ` Bernd Schmidt
2014-04-02 8:34 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADG=Z0GUi8UDookgwcd0AzDjWDS9pWyqt-c8GRyM3=gjrwg_zQ@mail.gmail.com' \
--to=iverbin@gmail.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=michael.v.zolotukhin@gmail.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).