From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14723 invoked by alias); 15 Mar 2016 16:22:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14712 invoked by uid 89); 15 Mar 2016 16:22:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=kumar, Kumar, mod, HTo:D*atmel.com X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Mar 2016 16:22:37 +0000 Received: by mail-wm0-f52.google.com with SMTP id p65so34386844wmp.0 for ; Tue, 15 Mar 2016 09:22:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=R7rOoauolN0gQFeE9fG90j/LobqST1Msprx6IFlybnk=; b=OPNXKtWZdwBz56SWsny6feC6+EtX1LP//Vc2r37cjTHk74bGagTS4+z7vRJWkBxXNp EdIaVjfuhvi7wxyZo/6w6TXdDMIFcw1JicD1xTEu/ehUSDSqHtBexY9Sov2PprsGTEdW 69nrORxJ1ulo9uBG3t817C0Qj28IFHAmztao4VCDyB00ykjvP3+p/K7RVLQjFrThp046 XKdnhuPFQ0PSx2U+T1B5zKubMaIyWY03JqsMVNQJpTce6cIUazyM96G/FlWQcRQEroAD wt5RTHN+TwdSm40F1JxxPgCtvnCOPZqNP8VlVFS8wNFMMPSUQcNHXGlgfZyumcNtMIif JyLQ== X-Gm-Message-State: AD7BkJJx2AoRCnTN54fPfNyDchcX/qm4JR/jMFLUeCZCs0vE9u4JvAfUwU/CfUdUO69ABPL74k64lJDUNKTrJA== X-Received: by 10.28.173.143 with SMTP id w137mr26186579wme.101.1458058954492; Tue, 15 Mar 2016 09:22:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.179.193 with HTTP; Tue, 15 Mar 2016 09:22:14 -0700 (PDT) In-Reply-To: <87pov2saxk.fsf@jaguar.corp.atmel.com> References: <87pov2saxk.fsf@jaguar.corp.atmel.com> From: Denis Chertykov Date: Tue, 15 Mar 2016 16:22:00 -0000 Message-ID: Subject: Re: [Patch, avr]Fix multiple ICE fallout of PR 69764 To: Senthil Kumar Selvaraj Cc: GCC Patches , Georg-Johann Lay Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-03/txt/msg00847.txt.bz2 2016-03-10 16:46 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > This patch fixes ~230 internal compiler errors that showed up after > the fix for PR 69764. After the patch, target backends need to > explicitly specify mode for operand 2 of shift and rotate patterns - > see md.texi mod at > https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/doc/md.texi?r1=233358&r2=233613&pathrev=233613. > > The avr backend had VOIDmode as the mode for rotl SPN, and this patch > sets it to the mode of the insn to fix the problem. > > Reg testing shows ICE fixes and no new failures. > > If this is ok, could someone commit please? I don't have commit > access. > > Regards > Senthil > > 2016-03-10 Senthil Kumar Selvaraj > > * config/avr/avr.md (rotl3): Set > mode for operand 2. Committed. Denis.