From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, Anatoly Sokolov <aesok@post.ru>,
Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,AVR]: Fix PR 43746
Date: Mon, 12 Sep 2011 09:37:00 -0000 [thread overview]
Message-ID: <CADOs=zZNivrfqZG-kUVJaKU8trHjubk6u59VT7M4Zi9o=6oOeg@mail.gmail.com> (raw)
In-Reply-To: <4E6904F9.2070806@gjlay.de>
2011/9/8 Georg-Johann Lay <avr@gjlay.de>:
> This patch adds support for named progmem sections.
>
> The problem with the current implementation is that all progmem stuff is put
> into .progmem.data and thus no -gc-sections will have effect or constant
> merging cannot merge constants/strings in progmem.
>
> This patch avoids the hard coded .progmem.data section attribute in
> avr_insert_attributes. Instead, it uses avr_asm_named_section and
> avr_asm_select_section to choose the right section resp. to add the correct
> section prefix for progmem data.
>
> Tested without regressions.
>
> Initially I intended to add a -fprogmem-sections command line option that works
> similar but independent to -fdata-section. That way data sections could be
> used and strings in progmem merged. However, I did not find a straight forward
> way without cluttering avr BE with lots of code from varasm.c. Thus, for now,
> there is no -fprogmem-sections, i.e. progmem-sections are in sync with
> data-sections.
>
> Ok to install?
Please, commit.
Denis.
prev parent reply other threads:[~2011-09-12 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 18:34 Georg-Johann Lay
2011-09-12 9:37 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zZNivrfqZG-kUVJaKU8trHjubk6u59VT7M4Zi9o=6oOeg@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=aesok@post.ru \
--cc=avr@gjlay.de \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).