From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org,
Eric Weddington <eric.weddington@atmel.com>,
Anatoly Sokolov <aesok@post.ru>
Subject: Re: Ping #1: [Patch, AVR, 4.6+trunk]: PR44643 addendum
Date: Mon, 04 Jul 2011 12:11:00 -0000 [thread overview]
Message-ID: <CADOs=zZSiV5G56UQD7srVABEMCLANh+o3edyiLeNr2r8FhOYVA@mail.gmail.com> (raw)
In-Reply-To: <4E119344.7050803@gjlay.de>
2011/7/4 Georg-Johann Lay <avr@gjlay.de>:
> Georg-Johann Lay wrote:
>
> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02318.html
>
>> avr_insert_attributes uses TREE_READONLY on get readonlyness of node.
>>
>> That does not work for C++ arrays: it gives false error
>> "variable must be const in order to be put into read-only section by
>> means of '__attribute__((progmem))'".
>>
>> This patch peels arrays and uses TYPE_READONLY.
>>
>> I did not open separate PR for this, tagged it as addendum to PR44643
>> instead.
>>
>> Lightly tested on own code. There is no 'progmem' in testsuite, so
>> from testsuite's perspective that code is dead, anyway...
>>
>> Johann
>>
>> PR target/44643
>> * config/avr/avr.c (avr_insert_attributes): Use TYPE_READONLY
>> instead of TREE_READONLY.
Approved.
Denis.
prev parent reply other threads:[~2011-07-04 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 10:28 Georg-Johann Lay
2011-07-04 10:21 ` Ping #1: " Georg-Johann Lay
2011-07-04 12:11 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zZSiV5G56UQD7srVABEMCLANh+o3edyiLeNr2r8FhOYVA@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=aesok@post.ru \
--cc=avr@gjlay.de \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).