From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7724 invoked by alias); 12 Aug 2012 09:13:08 -0000 Received: (qmail 7712 invoked by uid 22791); 12 Aug 2012 09:13:06 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_SV X-Spam-Check-By: sourceware.org Received: from mail-ee0-f47.google.com (HELO mail-ee0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Aug 2012 09:12:52 +0000 Received: by eekb57 with SMTP id b57so833258eek.20 for ; Sun, 12 Aug 2012 02:12:50 -0700 (PDT) Received: by 10.14.207.9 with SMTP id m9mr9777746eeo.5.1344762770856; Sun, 12 Aug 2012 02:12:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.101.13 with HTTP; Sun, 12 Aug 2012 02:12:30 -0700 (PDT) In-Reply-To: <50257DCB.4010508@gjlay.de> References: <50252E25.3020901@gjlay.de> <50253F90.7000102@gjlay.de> <50257DCB.4010508@gjlay.de> From: Denis Chertykov Date: Sun, 12 Aug 2012 09:13:00 -0000 Message-ID: Subject: Re: [Patch,AVR] PR54222: Add fixed point support To: Georg-Johann Lay Cc: "Weddington, Eric" , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg00696.txt.bz2 2012/8/11 Georg-Johann Lay : > Weddington, Eric schrieb: >>> >>> From: Georg-Johann Lay >>> >>> >>> The first step would be to bisect and find the patch that lead to >>> PR53923. It was not a change in the avr BE, so the question goes >>> to the authors of the respective patch. >>> >>> Up to now I didn't even try to bisect; that would take years on the >>> host that I have available... >>> >>>> My only real concern is that this is a major feature addition and >>>> the AVR port is currently broken. >>> >>> >>> I don't know if it's the avr port or some parts of the middle end that >>> don't cooperate with avr. >> >> >> I would really, really love to see fixed point support added in, >> especially since I know that Sean has worked on it for quite a while, >> and you've also done a lot of work in getting the patches in shape to >> get them committed. >> >> But, if the AVR port is currently broken (by whomever, and whatever >> patch) and a major feature like this can't be tested to make sure it >> doesn't break anything else in the AVR backend, then I'm hesitant to >> approve (even though I really want to approve). > > > I don't understand enough of DF to fix PR53923. The insn that leads > to the ICE is (in df-problems.c:dead_debug_insert_temp): > Today I have updated GCC svn tree and successfully compiled avr-gcc. The libgcc2-mulsc3.c from PR53923 also compiled without bugs. Denis. PS: May be I'm doing something wrong ? (I had too long vacations)