From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41168 invoked by alias); 3 Mar 2015 07:46:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41159 invoked by uid 89); 3 Mar 2015 07:46:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-yh0-f51.google.com Received: from mail-yh0-f51.google.com (HELO mail-yh0-f51.google.com) (209.85.213.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 03 Mar 2015 07:46:55 +0000 Received: by yhnv1 with SMTP id v1so646884yhn.2 for ; Mon, 02 Mar 2015 23:46:53 -0800 (PST) X-Received: by 10.236.28.199 with SMTP id g47mr24076648yha.7.1425368813494; Mon, 02 Mar 2015 23:46:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.86.132 with HTTP; Mon, 2 Mar 2015 23:46:33 -0800 (PST) In-Reply-To: <54F4BCA1.7080707@gjlay.de> References: <54F4BCA1.7080707@gjlay.de> From: Denis Chertykov Date: Tue, 03 Mar 2015 07:46:00 -0000 Message-ID: Subject: Re: [patch,avr]: Fix various problems with specs and specs file generation. To: Georg-Johann Lay Cc: GCC Patches , Joerg Wunsch , Joern Rennecke Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-03/txt/msg00117.txt.bz2 2015-03-02 22:40 GMT+03:00 Georg-Johann Lay : > The new specs file generation introduces several problems. This patch > > - Fix build warnings > > - Clean up unused code and the old, now dead specs definitions. > > - Removes unused files and adjust build scripts / rules. > > - Issues with avr-libc awareness: > > -- Makes specs-generation aware of avr-libc (include tm.h in build script > and depend on WITH_AVRLIBC). > > -- avr-libc implements functions in libm.a which usually live in libgcc, > hence add -lm to libgcc_spec, cf. PR54461. > > -- The new libdev.a is a feature of avr-libc and not available with, e.g., > newlib. Hence remove it from lib_spec if the compiler is not configured for > avr-libc (--with-avrlibc=no). > > - Many minor issues with option propagation. > > - -march had been added to multilib generation some time ago, but > driver_self_spec was not aware of that option. > > > Ok for trunk? Approved. > > > BTW, anyone knows what -march= is good for? It allows all kinds of silly > option combinations like "-march=avrtiny -mmcu=atmega8" without any > complaints. > > What's wrong with -mmcu=avr* ? All architecture names start with "avr", and > /no/ device name starts /with/ "avr", hence -mmcu= should be fine and work > as smooth as in the last 10 years. > > Why that -march= option? If there is not a good reason for -march=, I'd > propose to clean it up and use -mmcu=avr* instead. I do not remember. I guess that it's like -march / -mcpu in ARM target. Denis.