From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch,avr] PR81407: Error if progmem variable needs constructing.
Date: Wed, 12 Jul 2017 11:02:00 -0000 [thread overview]
Message-ID: <CADOs=zaJGqq3GVHRPEu2B2urqStEMT+CQC2v7VMao8mzBpyLMA@mail.gmail.com> (raw)
In-Reply-To: <eeed8253-3aa7-c950-290c-129003cd65f1@gjlay.de>
2017-07-12 12:45 GMT+04:00 Georg-Johann Lay <avr@gjlay.de>:
> Hi, if the C++ front-end decides that something will need constructing,
> it will silently put the stuff into .rodata so that according
> pgm_read_xxx will read garbage from .progmem.
>
> As proposed by Jason, this patch diagnoses such situations.
>
> Ok to commit?
>
> Johann
>
> PR target/81407
> * config/avr/avr.c (avr_encode_section_info)
> [progmem && !TREE_READONLY]: Error if progmem object needs
> constructing.
Approved.
prev parent reply other threads:[~2017-07-12 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 8:45 Georg-Johann Lay
2017-07-12 11:02 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zaJGqq3GVHRPEu2B2urqStEMT+CQC2v7VMao8mzBpyLMA@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=avr@gjlay.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).