From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45408 invoked by alias); 12 Jul 2017 11:02:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42588 invoked by uid 89); 12 Jul 2017 11:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-io0-f180.google.com Received: from mail-io0-f180.google.com (HELO mail-io0-f180.google.com) (209.85.223.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jul 2017 11:02:05 +0000 Received: by mail-io0-f180.google.com with SMTP id h134so10517622iof.2 for ; Wed, 12 Jul 2017 04:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o+CpwDl3ftQo9FfclS36NbL3MF6wsux3b2PMIVt6zVw=; b=RYQh+tedeTJssTOlVP7Jt8HdYy7J+S8r9quWZrPpRz7Df/OX+hBkUr5BoMuWDYvcI5 ZK/KsZlog+uNaK0UQogN1bVfizeJQj36DA6DiiqUhrJix8/+SxyIDVkTLgeeONIK+GX1 AlUgKqpG/2XkVKTDuQbxKfrDYZDna2ba4uTe546FFDhL4GhlRsr9z/FysI1Nc3QQ0Qjm Mj+BxxRueph7DRhF9SH3JTufZCCURwzFehWlpUQzU3fIXZDaWTVO9PnbFWPoiqgS6e7E GpoWvqSUTmtY7rlrIuO+bkpn40TT3SahdL2E+41Gh/jQJ4qgF1fvmiv213etBvcr6ItX 5IwQ== X-Gm-Message-State: AIVw1139GOhqCuZudYYG6k9KEOkGeGphHJjVg4I9vZziCnQm1n1PG/z4 eD+ZIwd3to23bSiN8+3MOP7i0z0NalcX X-Received: by 10.107.46.97 with SMTP id i94mr4456858ioo.192.1499857323790; Wed, 12 Jul 2017 04:02:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.165.3 with HTTP; Wed, 12 Jul 2017 04:01:43 -0700 (PDT) In-Reply-To: References: From: Denis Chertykov Date: Wed, 12 Jul 2017 11:02:00 -0000 Message-ID: Subject: Re: [patch,avr] PR81407: Error if progmem variable needs constructing. To: Georg-Johann Lay Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-07/txt/msg00581.txt.bz2 2017-07-12 12:45 GMT+04:00 Georg-Johann Lay : > Hi, if the C++ front-end decides that something will need constructing, > it will silently put the stuff into .rodata so that according > pgm_read_xxx will read garbage from .progmem. > > As proposed by Jason, this patch diagnoses such situations. > > Ok to commit? > > Johann > > PR target/81407 > * config/avr/avr.c (avr_encode_section_info) > [progmem && !TREE_READONLY]: Error if progmem object needs > constructing. Approved.