From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43273 invoked by alias); 11 Mar 2015 18:18:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43196 invoked by uid 89); 11 Mar 2015 18:18:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-yh0-f52.google.com Received: from mail-yh0-f52.google.com (HELO mail-yh0-f52.google.com) (209.85.213.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Mar 2015 18:18:23 +0000 Received: by yhot59 with SMTP id t59so5396677yho.7 for ; Wed, 11 Mar 2015 11:18:21 -0700 (PDT) X-Received: by 10.236.18.194 with SMTP id l42mr38022811yhl.172.1426097901645; Wed, 11 Mar 2015 11:18:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.86.132 with HTTP; Wed, 11 Mar 2015 11:18:01 -0700 (PDT) In-Reply-To: <54FF0788.6050108@gjlay.de> References: <54F4BCA1.7080707@gjlay.de> <20150303132144.GC24277@atmel.com> <54FDC417.1000008@gjlay.de> <54FF0788.6050108@gjlay.de> From: Denis Chertykov Date: Wed, 11 Mar 2015 18:18:00 -0000 Message-ID: Subject: Re: [patch,avr]: Part3 and 4: Fix various problems with specs and specs file generation. To: Georg-Johann Lay Cc: Senthil Kumar Selvaraj , GCC Patches , Joerg Wunsch Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-03/txt/msg00644.txt.bz2 2015-03-10 18:02 GMT+03:00 Georg-Johann Lay : > This is just a small addendum to the option and specs handling: > > - Document new avr-gcc command options > > - Change -march= to -mmcu= in some test cases > > - Add comfigure test to detect whether gas supports -mrmw and --mlink-relax. > > - Use result of these tests in specs generatio, i.e. omit respective options > if they are not supported. > > > Ok to apply? > > > Two issues remain: > > - The tests that add -mmcu= to the command options will fail because there > must not be more than one -mmcu=. Supporting several, incompatible MCUs > makes no sense (same for incompatible -march + -mmcu which was the case). > In 4.9 this works per accident with unspecified definitions for built-in > macros or when the options differ in default settings, for example. > > - Spaces in the installation path are not supported. It's possible to > recover from spaces in -specs= by escaping them in spec function > device-specs-file. However this is almost impossible for the device library > without changing gcc.c which can use convert_white_space() as needed. > Adding more than one escape level is not possible because the '\' would be > interpreted as part of the path. > > > Johann > > > gcc/ > PR target/65296 > * configure.ac [avr]: Check as for options -mrmw, --mlink-relax. > * configure: Regenerate. > * config.in: Regenerate. > * config/avr/gen-avr-mmcu-specs.c (config.h): Include it. > (*asm_relax): Only define spec if HAVE_AS_AVR_MLINK_RELAX_OPTION. > (*asm_rmw): Only define spec if HAVE_AS_AVR_MRMW_OPTION. > > > gcc/ > PR target/65296 > * doc/invoke.texi (AVR Options) [-mrmw]: Document it. > [-mn-flash]: Document it. > [__AVR_DEVICE_NAME__]: Document it. > [__ARV_ARCH__]: Document avrtiny. > > gcc/testsuite/ > PR target/65296 > * gcc.target/avr/tiny-memx: Use -mmcu instead of -march. > * gcc.target/avr/tiny-caller-save.c: Same. > > > gcc/ > PR target/65296 > * configure.ac [avr]: Check as for option -mrmw. > * configure: Regenerate. > * config.in: Regenerate. > * config/avr/driver-avr.c (avr_device_to_as): Don't add -mrmw to > assembler options if not HAVE_AS_AVR_MRMW_OPTION. > Approved. Denis.