From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, Anatoly Sokolov <aesok@post.ru>,
Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,AVR]: Fix PR50465
Date: Mon, 26 Sep 2011 12:38:00 -0000 [thread overview]
Message-ID: <CADOs=zao5RJpr2gDLci9OPxaekc0N=k=z6HT19eJL5PL2n3oeg@mail.gmail.com> (raw)
In-Reply-To: <4E8057BB.8060408@gjlay.de>
2011/9/26 Georg-Johann Lay <avr@gjlay.de>:
> This patch is housekeeping to clean up avr.c:adjust_insn_length i.e. replace
> digging in RTXes by using insn attribute "adjust_len".
>
> There's nothing special about it, it's just mechanical change.
>
> As alternative "yes" is no more needed, I removed it and set the default to
> "no": No insn needs length adjustment except stated otherwise.
>
> Passes without regressions.
>
> Ok?
>
> Johann
>
> PR target/50465
> * config/avr/avr-protos.h (output_reload_insisf): Don't pass insn.
> * config/avr/avr.md (*reload_insi, *reload_insf): Change call to
> output_reload_insisf.
> (adjust_len): Set default to "no".
> Remove alternative "yes". Add alternatives: "mov8", "mov16",
> "mov32", "ashlqi", "ashrqi", "lshrqi", "ashlhi", "ashrhi",
> "lshrhi", "ashlsi, "ashrsi", "lshrsi".
> (*movqi, *movhi, *movsi, *ashlqi3, ashlhi3, ashlsi3,
> *ashlhi3_const, *ashlsi3_const, ashrqi3, ashrhi3, ashrsi3,
> *ashrhi3_const, *ashrsi3_const, *lshrqi3, lshrhi3, *lshrhi3_const,
> *lshrsi3_const): Set attribute "adjust_len".
> * config/avr/avr.c (output_reload_insisf): Remove parameter "insn".
> (output_movsisf): Don't pass insn to output_reload_insisf.
> (adjust_insn_length): Handle new alternatives to adjust_len.
> Remove handling of ADJUST_LEN_YES. Clean up code.
Approved.
Denis.
prev parent reply other threads:[~2011-09-26 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 12:28 Georg-Johann Lay
2011-09-26 12:38 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zao5RJpr2gDLci9OPxaekc0N=k=z6HT19eJL5PL2n3oeg@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=aesok@post.ru \
--cc=avr@gjlay.de \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).