From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: "Sivanupandi, Pitchumani" <Pitchumani.Sivanupandi@atmel.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>,
"Selvaraj, Senthil_Kumar" <Senthil_Kumar.Selvaraj@atmel.com>
Subject: Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.
Date: Wed, 08 Apr 2015 08:28:00 -0000 [thread overview]
Message-ID: <CADOs=zb_dyo0tEONrff_O7genuOu6Mgg-EWHpg277RBMR=VFoQ@mail.gmail.com> (raw)
In-Reply-To: <5523CEDE.1060204@gjlay.de>
2015-04-07 15:34 GMT+03:00 Georg-Johann Lay <avr@gjlay.de>:
> Am 04/06/2015 um 11:54 AM schrieb Sivanupandi, Pitchumani:
>>
>> Hi Johann,
>>
>> Did you try running g++ tests?
>> It seems xgcc is invoked to get multilibs (from gcc/testsuite/lib/g++.exp)
>> which failed to find specs file.
>
>
>
> This is because libgloss.exp:get_multilibs (used from g++_init) runs xgcc
> ($compiler) without -B, i.e. without any prefix. Without prefix there is no
> way to determine where the specs files are located.
>
> Patching driver_self_specs to read a specs file by means of -specs= is,
> well, not very common. I don't know any other target which does that.
>
> As a work-around you can run the tests against the installed compiler.
>
> Denis, what do you think? I could add yet another fixme to avr backend like
> the following; that way there's no need to change dejagnu:
>
>
> Johann
>
> Index: config/avr/driver-avr.c
> ===================================================================
> --- config/avr/driver-avr.c (revision 221602)
> +++ config/avr/driver-avr.c (working copy)
> @@ -80,6 +80,20 @@ avr_devicespecs_file (int argc, const ch
> return X_NODEVLIB;
>
> case 1:
> + if (0 == strcmp ("device-specs", argv[0]))
> + {
> + /* FIXME: This means "device-specs%s" from
> avr.h:DRIVER_SELF_SPECS
> + has not been resolved to a path. That case can occur when the
> + c++ testsuite is run from the build directory. DejaGNU's
> + libgloss.exp:get_multilibs runs $compiler without -B, i.e.runs
> + xgcc without specifying a prefix. Without any prefix, there
> is
> + no means to find out where the specs files might be located.
> + get_multilibs runs xgcc --print-multi-lib, hence we don't
> + actually need information form a specs file and may skip it
> + altogether. */
> + return X_NODEVLIB;
> + }
> +
> mmcu = AVR_MMCU_DEFAULT;
> break;
>
I'm weak in dejagnu internals and c++ testsuite.
It looks like an acceptable solution.
Denis.
next prev parent reply other threads:[~2015-04-08 8:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 19:40 [patch,avr]: " Georg-Johann Lay
2015-03-03 7:46 ` Denis Chertykov
2015-03-03 13:20 ` Senthil Kumar Selvaraj
2015-03-09 16:03 ` [patch,avr]: Part2: " Georg-Johann Lay
2015-03-09 20:00 ` Denis Chertykov
2015-03-10 15:02 ` [patch,avr]: Part3 and 4: " Georg-Johann Lay
2015-03-11 18:18 ` Denis Chertykov
2015-03-16 18:18 ` [patch,avr]: Part5: " Georg-Johann Lay
2015-03-17 6:37 ` Denis Chertykov
2015-04-06 9:54 ` [patch,avr]: Part2: " Sivanupandi, Pitchumani
2015-04-07 12:34 ` Georg-Johann Lay
2015-04-08 8:28 ` Denis Chertykov [this message]
2015-04-08 11:25 ` Georg-Johann Lay
2015-04-09 10:59 ` Sivanupandi, Pitchumani
2015-04-09 11:23 ` Georg-Johann Lay
2015-04-09 12:55 ` Sivanupandi, Pitchumani
2015-04-15 10:17 ` Sivanupandi, Pitchumani
2015-04-17 14:03 ` [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574 Georg-Johann Lay
2015-04-17 14:43 ` Denis Chertykov
2015-04-17 15:32 ` Georg-Johann Lay
2015-04-17 16:46 ` Denis Chertykov
2015-04-09 11:44 ` [patch,avr,committed]: ad PR65296: work around device-specs file + dejagnu for c++ Georg-Johann Lay
2015-03-09 16:21 ` [patch,avr]: Fix various problems with specs and specs file generation Georg-Johann Lay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zb_dyo0tEONrff_O7genuOu6Mgg-EWHpg277RBMR=VFoQ@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=Pitchumani.Sivanupandi@atmel.com \
--cc=Senthil_Kumar.Selvaraj@atmel.com \
--cc=avr@gjlay.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=joerg_wunsch@uriah.heep.sax.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).