From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7127 invoked by alias); 28 Nov 2012 23:02:35 -0000 Received: (qmail 7039 invoked by uid 22791); 28 Nov 2012 23:02:32 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 23:02:09 +0000 Received: by mail-ob0-f175.google.com with SMTP id vb8so12998583obc.20 for ; Wed, 28 Nov 2012 15:02:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=4xeXinxXZWzfSY/blfbo2RYGIWcbfp6tAZvk6588jz0=; b=J6ku0lGumitZdeZEY1/C+h2SxKm6I9SxkL1R3yb8+w3zoFCu+WDnDAG7T4TULBu60E qsrCYvnkF7ywd7COFEX/30M9MgLRvqB8ZtnKmUvElzwxdbTyduxvHY98EVVtZrCtVCrG +uRlx6yhf2Vy5y8+8cNSgqeko2a0aa1E3AbqOiEnB/3l0am0u5wmVDzcLSyLm1SLr4J2 DTNirrv+iAXDdQPfZ4VB/T+ivXPwT6P6DQRJb0hol90HGp/LxKDCUTcrjFoDGH4GHGtY wWUhf4/NL7MIAHr+gZN1H6SUaxEHvYHMmWEdEEbjFNcGO5qbGclA/6pWjNSpNgtwa26k veAA== MIME-Version: 1.0 Received: by 10.182.174.39 with SMTP id bp7mr6353657obc.1.1354143728537; Wed, 28 Nov 2012 15:02:08 -0800 (PST) Received: by 10.76.174.101 with HTTP; Wed, 28 Nov 2012 15:02:08 -0800 (PST) In-Reply-To: References: Date: Wed, 28 Nov 2012 23:02:00 -0000 Message-ID: Subject: Re: [RFA 3/8] validate_failures.py: pass options.results for clean build case From: Doug Evans To: Diego Novillo Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnm38+DaJnVNnSPZ3/fXVD7fBLakwO0o+vpIyh1ri9egTp5TPOJrf2MSUsc9ubVhhI0FWZiohD47RCvFNSivFvO7yG57CiATrnixW28lR22nw/kPdWwmm3Vc5kSXqUJrq/js6Xp0ACJscsvIAP00ABlx9+rxS+SDwSUMD+R7CoBys0X57+pnQsuYcOBU7GF23lNveJA X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02380.txt.bz2 On Wed, Nov 28, 2012 at 12:35 PM, Diego Novillo wrote: > On Wed, Nov 28, 2012 at 1:55 PM, Doug Evans wrote: > >> In gdb-land, parallel make check runs collect all the subdirectory >> .sum files and reconstruct testsuite/${tool}.sum. >> >> There's more than one solution of course: alternatively one could have >> gdb stop doing this. But I'm not sure which is better, and rather >> than change gdb I went for changing validate_failure.py (which made >> sense regardless of what gdb is doing: use the same .sum files in the >> comparison). Could be missing something of course. :-) > > So, you do have a set of .sum files, right? You could feed them to > validate_failures.py via --manifest=collected_results_from_gdb.sum. > You do not need to use the --clean_build flag. > > What I'm saying is that from a user perspective, it doesn't really > make sense to use --clean_build and --manifest together. If you have > the --manifest, you do not need to go to --clean_build to look for the > .sum files. > > Am I right in understanding that you are intending to call > > $ validate_failures.py --clean_build=/path/to/gdb/bld > --manifest=/path/to/gdb.sum ? > > If that's not what you are intending, then I am completely lost :) s/--manifest/--results/ i.e. $ validate_failures.py --clean_build=/path/to/gdb/bld --results=/path/to/gdb.sum ...