From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-332069-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16177 invoked by alias); 16 Nov 2012 15:40:47 -0000
Received: (qmail 16169 invoked by uid 22791); 16 Nov 2012 15:40:46 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_CP
X-Spam-Check-By: sourceware.org
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Nov 2012 15:40:42 +0000
Received: by mail-ob0-f175.google.com with SMTP id vb8so2936847obc.20        for <gcc-patches@gcc.gnu.org>; Fri, 16 Nov 2012 07:40:41 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :content-type:x-gm-message-state;        bh=MCX9g+92cbLzeGB4ov8GK+8yUmYZ5itLukA0TmIqep4=;        b=QvAeRwrOQB+94N0fK0xCzbRkNgMspdAiAoZe7ZfACyhWlNefHBbkrB6hwJmX9fghcZ         ItiKv/9aD64lPukw36asEIQZBvdyviKsOoD7174TjUNNFcD3LZL3Ml3n9HqE5CoS6RTw         hX9yuBf5UJYjq6LbK+1JehdGMCRsjyulGUtXGAtLWQk8kiR1Z+W0cFUjXW9ED68u3CSO         XWfAZQipTlbZMwkIGmzAD5k6mG0FtsU+6kkuWCRE5j490uR5ffpqngxueLejFvAJlNU1         R5tJZM9VgMCE8KFK8oowCfZFk4lgwuod+zVrIdu+LtKDaggz6mqWLFbVTNwLY0jBvZcj         /RIQ==
MIME-Version: 1.0
Received: by 10.60.13.132 with SMTP id h4mr4256824oec.72.1353080441740; Fri, 16 Nov 2012 07:40:41 -0800 (PST)
Received: by 10.76.170.170 with HTTP; Fri, 16 Nov 2012 07:40:41 -0800 (PST)
In-Reply-To: <87r4nu7aaj.fsf@talisman.default>
References: <20121115215412.3B1F6C0916@torture.tor.corp.google.com>	<87r4nu7aaj.fsf@talisman.default>
Date: Fri, 16 Nov 2012 15:40:00 -0000
Message-ID: <CAD_=9DQOOAH4NSXWQ2eRuyBjug=ezSo38TAbov0DVgaXQpqYiQ@mail.gmail.com>
Subject: Re: VEC re-write [patch 18/25]
From: Diego Novillo <dnovillo@google.com>
To: Diego Novillo <dnovillo@google.com>, gcc-patches@gcc.gnu.org, 	rdsandiford@googlemail.com
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQlouitpLYJNHWyIquNVOCx203Q9M9Pk1EFtcLLlSFbrHXaH2x8+whxKV29WOM9D8vtqenuDbRRzVInE5ZJa0OoVQt9aw7HQjq4mgKJcOJFEUfYsdJvtsGgwuQg6NnN2cwDpQRD3sEfZSALm44jq6MX6lgXUTZaYKIrAU/hGjRAm8fgy3uhk9G9/P3wlqhf8efvWSwmu
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-11/txt/msg01391.txt.bz2

On Thu, Nov 15, 2012 at 5:48 PM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:

>> @@ -4013,11 +4013,9 @@ struct mips_multi_member {
>>  typedef struct mips_multi_member mips_multi_member;
>>
>>  /* Vector definitions for the above.  */
>> -DEF_VEC_O(mips_multi_member);
>> -DEF_VEC_ALLOC_O(mips_multi_member, heap);
>
> Please delete the comment too.

Done.

>
>> @@ -4093,7 +4091,7 @@ mips_multi_copy_insn (unsigned int i)
>>    struct mips_multi_member *member;
>>
>>    member = mips_multi_add ();
>> -  memcpy (member, &VEC_index (mips_multi_member, mips_multi_members, i),
>> +  memcpy (member, &mips_multi_members[i],
>>         sizeof (*member));
>>    gcc_assert (!member->is_label_p);
>>  }
>
> This call now fits comfortably onto one line.

Done.

Diego.