From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055)
Date: Tue, 12 Jul 2011 19:50:00 -0000 [thread overview]
Message-ID: <CAD_=9DRF-hzOy1crhSwGvQ1Be-xQB6NfS1YGS2Zn4U6YF1oQ7Q@mail.gmail.com> (raw)
In-Reply-To: <20110709012047.0D90B1C36BA@gchare.mtv.corp.google.com>
On Fri, Jul 8, 2011 at 21:20, Gabriel Charette <gchare@google.com> wrote:
> 2011-07-08 Gabriel Charette <gchare@google.com>
>
> * pph-streamer-in.c (pph_in_function_decl): Stream in
> DECL_CHAIN of FUNCTION_DECL only if it's part of a RECORD_OR_UNION_TYPE
> (pph_read_tree): Stream in DECL_CHAIN of VAR_DECL only if it's part
> of a RECORD_OR_UNION_TYPE.
> * pph-streamer-out.c (pph_out_function_decl): Stream out
> DECL_CHAIN of FUNCTION_DECL only if it's part of a RECORD_OR_UNION_TYPE
> (pph_write_tree): Stream out DECL_CHAIN of VAR_DECL only if it's part
> of a RECORD_OR_UNION_TYPE.
Gab, do you still need this patch? In principle, it doesn't make a
lot of sense to restrict when we save the DECL_CHAIN in this way.
It's not obvious what this would fix or help with.
Diego.
next prev parent reply other threads:[~2011-07-12 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 10:13 Gabriel Charette
2011-07-12 19:50 ` Diego Novillo [this message]
2011-07-12 20:56 ` Gabriel Charette
2011-07-12 23:26 ` Diego Novillo
2011-07-13 1:05 ` Gabriel Charette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD_=9DRF-hzOy1crhSwGvQ1Be-xQB6NfS1YGS2Zn4U6YF1oQ7Q@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).