From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24996 invoked by alias); 12 Jul 2011 19:21:54 -0000 Received: (qmail 24984 invoked by uid 22791); 12 Jul 2011 19:21:53 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jul 2011 19:21:39 +0000 Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) by smtp-out.google.com with ESMTP id p6CJLXU2021200 for ; Tue, 12 Jul 2011 12:21:34 -0700 Received: from gyf3 (gyf3.prod.google.com [10.243.50.67]) by wpaz9.hot.corp.google.com with ESMTP id p6CJLWGG027651 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 12 Jul 2011 12:21:32 -0700 Received: by gyf3 with SMTP id 3so2596442gyf.13 for ; Tue, 12 Jul 2011 12:21:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.15.5 with SMTP id s5mr518856ybi.241.1310498492304; Tue, 12 Jul 2011 12:21:32 -0700 (PDT) Received: by 10.151.142.15 with HTTP; Tue, 12 Jul 2011 12:21:32 -0700 (PDT) In-Reply-To: <20110709012047.0D90B1C36BA@gchare.mtv.corp.google.com> References: <20110709012047.0D90B1C36BA@gchare.mtv.corp.google.com> Date: Tue, 12 Jul 2011 19:50:00 -0000 Message-ID: Subject: Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055) From: Diego Novillo To: Gabriel Charette Cc: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00954.txt.bz2 On Fri, Jul 8, 2011 at 21:20, Gabriel Charette wrote: > 2011-07-08 =C2=A0Gabriel Charette =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* pph-streamer-in.c (pph_in_function_decl): St= ream in > =C2=A0 =C2=A0 =C2=A0 =C2=A0DECL_CHAIN of FUNCTION_DECL only if it's part = of a RECORD_OR_UNION_TYPE > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pph_read_tree): Stream in DECL_CHAIN of VAR_D= ECL only if it's part > =C2=A0 =C2=A0 =C2=A0 =C2=A0of a RECORD_OR_UNION_TYPE. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* pph-streamer-out.c (pph_out_function_decl): = Stream out > =C2=A0 =C2=A0 =C2=A0 =C2=A0DECL_CHAIN of FUNCTION_DECL only if it's part = of a RECORD_OR_UNION_TYPE > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pph_write_tree): Stream out DECL_CHAIN of VAR= _DECL only if it's part > =C2=A0 =C2=A0 =C2=A0 =C2=A0of a RECORD_OR_UNION_TYPE. Gab, do you still need this patch? In principle, it doesn't make a lot of sense to restrict when we save the DECL_CHAIN in this way. It's not obvious what this would fix or help with. Diego.