* [PATCH] Fix output in mklog
@ 2012-05-31 20:12 Marek Polacek
2012-06-06 9:00 ` Marek Polacek
2012-06-06 11:11 ` Diego Novillo
0 siblings, 2 replies; 5+ messages in thread
From: Marek Polacek @ 2012-05-31 20:12 UTC (permalink / raw)
To: GCC Patches
The new mklog script prints three spaces after the date part, which
is wrong. Thus fixed by adjusting the split pattern. Tested manually.
2012-05-31 Marek Polacek <polacek@redhat.com>
* mklog: Prevent printing three spaces after the date.
--- gcc/contrib/mklog.mp 2012-05-31 22:03:07.492457065 +0200
+++ gcc/contrib/mklog 2012-05-31 22:03:21.824493596 +0200
@@ -29,7 +29,7 @@
# Change these settings to reflect your profile.
$username = $ENV{'USER'};
$name = `finger $username | grep -o 'Name: .*'`;
-@n = split(/:/, $name);
+@n = split(/: /, $name);
$name = @n[1]; chop($name);
$addr = $username . "\@my.domain.org";
$date = `date +%Y-%m-%d`; chop ($date);
Marek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix output in mklog
2012-05-31 20:12 [PATCH] Fix output in mklog Marek Polacek
@ 2012-06-06 9:00 ` Marek Polacek
2012-06-06 11:11 ` Diego Novillo
1 sibling, 0 replies; 5+ messages in thread
From: Marek Polacek @ 2012-06-06 9:00 UTC (permalink / raw)
To: GCC Patches; +Cc: Diego Novillo
Ping.
On Thu, May 31, 2012 at 10:12:09PM +0200, Marek Polacek wrote:
> The new mklog script prints three spaces after the date part, which
> is wrong. Thus fixed by adjusting the split pattern. Tested manually.
>
> 2012-05-31 Marek Polacek <polacek@redhat.com>
>
> * mklog: Prevent printing three spaces after the date.
>
> --- gcc/contrib/mklog.mp 2012-05-31 22:03:07.492457065 +0200
> +++ gcc/contrib/mklog 2012-05-31 22:03:21.824493596 +0200
> @@ -29,7 +29,7 @@
> # Change these settings to reflect your profile.
> $username = $ENV{'USER'};
> $name = `finger $username | grep -o 'Name: .*'`;
> -@n = split(/:/, $name);
> +@n = split(/: /, $name);
> $name = @n[1]; chop($name);
> $addr = $username . "\@my.domain.org";
> $date = `date +%Y-%m-%d`; chop ($date);
>
> Marek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix output in mklog
2012-05-31 20:12 [PATCH] Fix output in mklog Marek Polacek
2012-06-06 9:00 ` Marek Polacek
@ 2012-06-06 11:11 ` Diego Novillo
2012-06-06 12:51 ` Marek Polacek
1 sibling, 1 reply; 5+ messages in thread
From: Diego Novillo @ 2012-06-06 11:11 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Thu, May 31, 2012 at 4:12 PM, Marek Polacek <polacek@redhat.com> wrote:
> 2012-05-31 Marek Polacek <polacek@redhat.com>
>
> * mklog: Prevent printing three spaces after the date.
OK.
Diego.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix output in mklog
2012-06-06 11:11 ` Diego Novillo
@ 2012-06-06 12:51 ` Marek Polacek
2012-06-06 12:53 ` Diego Novillo
0 siblings, 1 reply; 5+ messages in thread
From: Marek Polacek @ 2012-06-06 12:51 UTC (permalink / raw)
To: Diego Novillo; +Cc: GCC Patches
On Wed, Jun 06, 2012 at 07:09:08AM -0400, Diego Novillo wrote:
> On Thu, May 31, 2012 at 4:12 PM, Marek Polacek <polacek@redhat.com> wrote:
>
> > 2012-05-31  Marek Polacek  <polacek@redhat.com>
> >
> > Â Â Â Â * mklog: Prevent printing three spaces after the date.
>
> OK.
Sorry, I don't have commit rights, so I'm not able to apply this
one myself. Thanks,
Marek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix output in mklog
2012-06-06 12:51 ` Marek Polacek
@ 2012-06-06 12:53 ` Diego Novillo
0 siblings, 0 replies; 5+ messages in thread
From: Diego Novillo @ 2012-06-06 12:53 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Wed, Jun 6, 2012 at 8:44 AM, Marek Polacek <polacek@redhat.com> wrote:
> Sorry, I don't have commit rights, so I'm not able to apply this
> one myself. Thanks,
Committed rev 188265. Thanks for the fix.
Diego.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-06 12:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-31 20:12 [PATCH] Fix output in mklog Marek Polacek
2012-06-06 9:00 ` Marek Polacek
2012-06-06 11:11 ` Diego Novillo
2012-06-06 12:51 ` Marek Polacek
2012-06-06 12:53 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).