* Re: [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061)
@ 2012-06-01 0:10 asharif
2012-06-05 13:16 ` Diego Novillo
0 siblings, 1 reply; 2+ messages in thread
From: asharif @ 2012-06-01 0:10 UTC (permalink / raw)
To: xur, davidxl, iant, dnovillo; +Cc: gcc-patches, reply
Reviewers: xur, davidxl, iant2, Diego Novillo,
Message:
The relevant bug is this:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.
Please take a look and provide feedback.
Thanks,
Description:
2012-05-31 Ahmad Sharif <asharif@google.com>
* gcc/dwarf2asm.c: (dw2_output_indirect_constant_1): Copy TREE_STATIC()
attribute from id to decl.
Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c (revision 188089)
+++ gcc/dwarf2asm.c (working copy)
@@ -907,6 +907,7 @@
DECL_IGNORED_P (decl) = 1;
DECL_INITIAL (decl) = decl;
TREE_READONLY (decl) = 1;
+ TREE_STATIC (decl) = TREE_STATIC (id);
if (TREE_PUBLIC (id))
{
@@ -915,8 +916,6 @@
if (USE_LINKONCE_INDIRECT)
DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
}
- else
- TREE_STATIC (decl) = 1;
sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
assemble_variable (decl, 1, 1, 1);
Please review this at http://codereview.appspot.com/6133061/
Affected files:
M gcc/dwarf2asm.c
2012-04-30 Ahmad Sharif <asharif@google.com>
* gcc/dwarf2asm.c: copy TREE_STATIC() property from id.
Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c (revision 186998)
+++ gcc/dwarf2asm.c (working copy)
@@ -907,6 +907,7 @@
DECL_IGNORED_P (decl) = 1;
DECL_INITIAL (decl) = decl;
TREE_READONLY (decl) = 1;
+ TREE_STATIC (decl) = TREE_STATIC (id);
if (TREE_PUBLIC (id))
{
@@ -915,8 +916,6 @@
if (USE_LINKONCE_INDIRECT)
DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
}
- else
- TREE_STATIC (decl) = 1;
sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
assemble_variable (decl, 1, 1, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061)
2012-06-01 0:10 [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061) asharif
@ 2012-06-05 13:16 ` Diego Novillo
0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2012-06-05 13:16 UTC (permalink / raw)
To: asharif, xur, davidxl, iant, dnovillo, gcc-patches, reply
On Thu, May 31, 2012 at 8:10 PM, <asharif@chromium.org> wrote:
> Reviewers: xur, davidxl, iant2, Diego Novillo,
>
> Message:
> The relevant bug is this:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.
This bug does not affect trunk. Only the google branches where LIPO
is implemented.
Diego.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-05 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-01 0:10 [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061) asharif
2012-06-05 13:16 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).