From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29300 invoked by alias); 17 Dec 2012 15:09:15 -0000 Received: (qmail 29284 invoked by uid 22791); 17 Dec 2012 15:09:14 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ee0-f47.google.com (HELO mail-ee0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 15:09:08 +0000 Received: by mail-ee0-f47.google.com with SMTP id e51so3228478eek.20 for ; Mon, 17 Dec 2012 07:09:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=i/K2JxADkjAeM2DZZlW4fLwRqgaP+x3yXwv6xiU7mrM=; b=SuoomR7CDrq19C0/yTmkf2+E9nJT4eQrRU6ww9CBayFBk2PqiqlXojhfz+pwJAhnot FA3bPQYRcSshTvPTwjq3UfyV6M2jZKWikeDJxiEBY2QY0FA7HYq70ADUZ//31O40qxep Ti6cOwc/HkVRDGCt7qkj0qqz9CPHtts5ecVcO6JXjvJ/Q/BCy2e3M6ikWjIFB9dBAV1J 3CcIT2jelSliYRUAM6m3T2iTHkyr/4epyhjV/2Do7uSR889iiJF1AndB3WviM48yeSnl AjgfwvFTATEhAONK/TWfLHO3LjDy9LLtrnIA5LffbSC8a1zhlti21N+vpNnYSudkD0vB NhIA== MIME-Version: 1.0 Received: by 10.14.0.71 with SMTP id 47mr41494310eea.19.1355756947157; Mon, 17 Dec 2012 07:09:07 -0800 (PST) Received: by 10.223.161.209 with HTTP; Mon, 17 Dec 2012 07:09:06 -0800 (PST) In-Reply-To: <20121213151219.GB19295@mx.loc> References: <20121205073542.GA23452@mx.loc> <1354817522-18274-1-git-send-email-rep.dot.nop@gmail.com> <20121213151219.GB19295@mx.loc> Date: Mon, 17 Dec 2012 15:09:00 -0000 Message-ID: Subject: Re: [PATCH] validate_failures.py: Fix performance regression From: Diego Novillo To: Bernhard Reutner-Fischer Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkt+t3Kl3tCMs/Dm0wlx7dhZaFO/sNM/1nWsbfROS35waNEkrqp9XmWOKmirfH3Oguq1RjrDaA0gZEVG4ZBjmRIZxa+7DSFwV8PQHTuKhHL9m44eon11nN11nHQcy96UjHzmVgaL6zPsHgpYPtJozMIudqp/7aPQpRBeswMogPpzg2o57+0ccYqfCjGrBZcMzSyncQJ X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg01062.txt.bz2 On Thu, Dec 13, 2012 at 10:12 AM, Bernhard Reutner-Fischer wrote: > On Fri, Dec 07, 2012 at 10:31:57AM -0500, Diego Novillo wrote: >>On Thu, Dec 6, 2012 at 1:12 PM, Bernhard Reutner-Fischer >> wrote: > > @@ -210,12 +211,12 @@ def IsInterestingResult(line): > if '|' in line: > (_, line) = line.split('|', 1) > line = line.strip() > - return any(line.startswith(result) for result in _VALID_TEST_RESULTS) > + return bool(_VALID_TEST_RESULTS_REX.match(line)) > > I wonder why we care about '|' at all? Can you give an example where > this is of relevance? That's for the attributes. See the syntax at the top of the file. One can add an attribute to a test. For instance, mark it 'flaky' so it's always ignored. Or you can add an expiration date, to ignore it until that timer elapses. > or, if there ever is a pipe in an interesting result > def IsInterestingResult(line): > """Return True if line is one of the summary lines we care about.""" > if bool(_VALID_TEST_RESULTS_REX.match(line)): > if '|' in line: > (line, _) = line.split('|', 1) > line = line.strip() > return True > return False *shrug* Performance is not really a problem with this script. Diego.