From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Remove protection for NAMESPACE_LEVEL being null when adding namespaces (issue4675069)
Date: Tue, 12 Jul 2011 12:54:00 -0000 [thread overview]
Message-ID: <CAD_=9DTi_DiiKTsDXJ_qP6bNjkOfmiDsncCT1prHLVfghVB8Rw@mail.gmail.com> (raw)
In-Reply-To: <20110709012935.B28761C3720@gchare.mtv.corp.google.com>
On Fri, Jul 8, 2011 at 21:29, Gabriel Charette <gchare@google.com> wrote:
> 2011-07-08 Gabriel Charette <gchare@google.com>
>
> * gcc/cp/pph-streamer-in.c (pph_add_bindings_to_namespace):
> NAMESPACE_LEVEL should never be null for a namespace, removed check.
OK. I committed it to the branch. I need to adjust the other two
patches you sent as I'm starting to fix something in the same area.
Diego.
prev parent reply other threads:[~2011-07-12 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 10:15 Gabriel Charette
2011-07-12 12:54 ` Diego Novillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD_=9DTi_DiiKTsDXJ_qP6bNjkOfmiDsncCT1prHLVfghVB8Rw@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).