public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [google gcc-4_7] Backport r195207 (fix for PR55982) into google/gcc-4_7
@ 2013-01-15 18:42 Paul Pluzhnikov
  2013-01-15 18:46 ` Diego Novillo
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Pluzhnikov @ 2013-01-15 18:42 UTC (permalink / raw)
  To: dnovillo, gcc-patches; +Cc: ppluzhnikov

Ok for google/gcc-4_7 ?

Ref b/8003094

Thanks,
--
Paul Pluzhnikov


2013-01-15  Paul Pluzhnikov  <ppluzhnikov@google.com>

	PR 55982
	* strncat-chk.c (__strncat_chk): Fix loop unroll.


Index: libssp/strncat-chk.c
===================================================================
--- libssp/strncat-chk.c	(revision 195212)
+++ libssp/strncat-chk.c	(working copy)
@@ -87,12 +87,6 @@ __strncat_chk (char *__restrict__ dest, const char
           *++dest = c;
           if (c == '\0')
             return s;
-          if (slen-- == 0)
-            __chk_fail ();
-          c = *src++;
-          *++dest = c;
-          if (c == '\0')
-            return s;
         } while (--n4 > 0);
       n &= 3;
     }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [google gcc-4_7] Backport r195207 (fix for PR55982) into google/gcc-4_7
  2013-01-15 18:42 [google gcc-4_7] Backport r195207 (fix for PR55982) into google/gcc-4_7 Paul Pluzhnikov
@ 2013-01-15 18:46 ` Diego Novillo
  0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2013-01-15 18:46 UTC (permalink / raw)
  To: Paul Pluzhnikov; +Cc: gcc-patches

On Tue, Jan 15, 2013 at 1:42 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> Ok for google/gcc-4_7 ?
>
> Ref b/8003094
>
> Thanks,
> --
> Paul Pluzhnikov
>
>
> 2013-01-15  Paul Pluzhnikov  <ppluzhnikov@google.com>
>
>         PR 55982
>         * strncat-chk.c (__strncat_chk): Fix loop unroll.
>
>
> Index: libssp/strncat-chk.c
> ===================================================================
> --- libssp/strncat-chk.c        (revision 195212)
> +++ libssp/strncat-chk.c        (working copy)
> @@ -87,12 +87,6 @@ __strncat_chk (char *__restrict__ dest, const char
>            *++dest = c;
>            if (c == '\0')
>              return s;
> -          if (slen-- == 0)
> -            __chk_fail ();
> -          c = *src++;
> -          *++dest = c;
> -          if (c == '\0')
> -            return s;
>          } while (--n4 > 0);
>        n &= 3;
>      }

OK.  No need to add a ChangeLog entry.  Simply put your message in the
commit log entry.


Diego.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-15 18:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-15 18:42 [google gcc-4_7] Backport r195207 (fix for PR55982) into google/gcc-4_7 Paul Pluzhnikov
2013-01-15 18:46 ` Diego Novillo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).