* [pph] Mark c4pr36533.cc fixed (issue4708041)
@ 2011-07-12 13:55 Diego Novillo
2011-07-12 18:09 ` Gabriel Charette
0 siblings, 1 reply; 3+ messages in thread
From: Diego Novillo @ 2011-07-12 13:55 UTC (permalink / raw)
To: reply, crowl, gchare, gcc-patches
Not quite sure what patch fixed this one and I'm too lazy to figure it out
now.
Committed to branch.
Diego.
* g++.dg/pph/c4pr36533.cc: Mark fixed.
diff --git a/gcc/testsuite/g++.dg/pph/c4pr36533.cc b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
index 0093db1..ce2bf1f 100644
--- a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
+++ b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
@@ -1,3 +1,2 @@
/* { dg-options "-w -fpermissive" } */
-// pph asm xdiff
#include "c4pr36533.h"
--
This patch is available for review at http://codereview.appspot.com/4708041
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pph] Mark c4pr36533.cc fixed (issue4708041)
2011-07-12 13:55 [pph] Mark c4pr36533.cc fixed (issue4708041) Diego Novillo
@ 2011-07-12 18:09 ` Gabriel Charette
2011-07-12 18:20 ` Diego Novillo
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Charette @ 2011-07-12 18:09 UTC (permalink / raw)
To: Diego Novillo; +Cc: reply, crowl, gcc-patches
My patch at http://codereview.appspot.com/4657092/ was fixing this.
Did you apply that already? I didn't see it as part of your commits to date?
Gab
On Tue, Jul 12, 2011 at 5:55 AM, Diego Novillo <dnovillo@google.com> wrote:
>
> Not quite sure what patch fixed this one and I'm too lazy to figure it out
> now.
>
> Committed to branch.
>
>
> Diego.
>
> * g++.dg/pph/c4pr36533.cc: Mark fixed.
>
> diff --git a/gcc/testsuite/g++.dg/pph/c4pr36533.cc b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> index 0093db1..ce2bf1f 100644
> --- a/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> +++ b/gcc/testsuite/g++.dg/pph/c4pr36533.cc
> @@ -1,3 +1,2 @@
> /* { dg-options "-w -fpermissive" } */
> -// pph asm xdiff
> #include "c4pr36533.h"
>
> --
> This patch is available for review at http://codereview.appspot.com/4708041
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pph] Mark c4pr36533.cc fixed (issue4708041)
2011-07-12 18:09 ` Gabriel Charette
@ 2011-07-12 18:20 ` Diego Novillo
0 siblings, 0 replies; 3+ messages in thread
From: Diego Novillo @ 2011-07-12 18:20 UTC (permalink / raw)
To: Gabriel Charette; +Cc: reply, crowl, gcc-patches
On Tue, Jul 12, 2011 at 14:02, Gabriel Charette <gchare@google.com> wrote:
> My patch at http://codereview.appspot.com/4657092/ was fixing this.
>
> Did you apply that already? I didn't see it as part of your commits to date?
Ah, so that was it. No, it wasn't 4657092. I think we both fixed
this independently. I now have a variant of 4657092 in my tree, but
it's still causing other grief. I should have it ready today.
Diego.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-12 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-12 13:55 [pph] Mark c4pr36533.cc fixed (issue4708041) Diego Novillo
2011-07-12 18:09 ` Gabriel Charette
2011-07-12 18:20 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).