public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Charles Baylis <charles.baylis@linaro.org>
To: Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
		Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Alan Lawrence <alan.lawrence@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages
Date: Fri, 09 Oct 2015 14:04:00 -0000	[thread overview]
Message-ID: <CADnVucCetW26xKKMsk7MUW_7HSxsnzo-RChYjes3i2QbyZC5hw@mail.gmail.com> (raw)
In-Reply-To: <1444175989-24944-1-git-send-email-charles.baylis@linaro.org>

On 7 October 2015 at 00:59,  <charles.baylis@linaro.org> wrote:
> From: Charles Baylis <charles.baylis@linaro.org>
>
> This patch series fixes up the error messages for single lane vector
> load/stores, similarly to AArch64.
>
> make check on arm-linux-gnueabihf/qemu completes with no new regressions.
>
> Changes since the last version:
> . removed the duplicate arm_neon_lane_bounds function
> . resolved conflicts with other NEON work
> . whitespace clean up
>

A bit more info is required here.

Original patch submission was at:
https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00142.html

> Charles Baylis (3):
>   [ARM] PR63870 Add qualifiers for NEON builtins

This adds the qualifier_struct_load_store_lane_index qualifier, ported
from my AArch64 changes. This causes the lane bounds check to be
performed and, on big-endian targets, reverses the lane number used in
the RTL (in common with other NEON patterns). This isn't strictly
required for correctness, since the vectorizer never generates these
patterns, but the consistency seems like a good idea.

>   [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate
>     qualifier

This marks the builtins with qualifier_struct_load_store_lane_index.
The patterns are also updated to un-reverse the lane order at assembly
time.

>   [ARM] PR63870 Enable test cases for ARM

Removes the xfails from the test cases.

      parent reply	other threads:[~2015-10-09 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07  0:00 charles.baylis
2015-10-07  0:00 ` [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins charles.baylis
2015-10-12 10:58   ` Alan Lawrence
2015-10-14 22:02     ` Charles Baylis
2015-10-19 16:59       ` Alan Lawrence
2015-10-07  0:00 ` [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier charles.baylis
2015-10-12 10:50   ` Alan Lawrence
2015-10-07  0:01 ` [PATCH 3/3] [ARM] PR63870 Enable test cases charles.baylis
2015-10-09 14:04 ` Charles Baylis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnVucCetW26xKKMsk7MUW_7HSxsnzo-RChYjes3i2QbyZC5hw@mail.gmail.com \
    --to=charles.baylis@linaro.org \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=alan.lawrence@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).