From: Charles Baylis <charles.baylis@linaro.org>
To: Alan Lawrence <alan.lawrence@arm.com>
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins
Date: Wed, 14 Oct 2015 22:02:00 -0000 [thread overview]
Message-ID: <CADnVucCrVZDr3xrag-GYdURLHLFrYnz_PKnP8QFZP7=-a-wYLg@mail.gmail.com> (raw)
In-Reply-To: <561B9242.1060506@arm.com>
On 12 October 2015 at 11:58, Alan Lawrence <alan.lawrence@arm.com> wrote:
> On 07/10/15 00:59, charles.baylis@linaro.org wrote:
>>
>> diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c
>
> ...
>>
>> case NEON_ARG_MEMORY:
>> /* Check if expand failed. */
>> if (op[argc] == const0_rtx)
>> {
>> - va_end (ap);
>> return 0;
>> }
>
>
> ...and drop the braces?
Will do.
>> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
>> index 02f5dc3..448cde3 100644
>> --- a/gcc/config/arm/arm.c
>> +++ b/gcc/config/arm/arm.c
>> @@ -30117,4 +30117,5 @@ arm_sched_fusion_priority (rtx_insn *insn, int
>> max_pri,
>> *pri = tmp;
>> return;
>> }
>> +
>> #include "gt-arm.h"
>
>
> This looks unrelated (and is the only change to arm.c) - perhaps commit
> separately? (Note I am not a maintainer! But this looks "obvious"...)
It doesn't seem very useful. I'll drop it.
>> diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h
>> index 87c9f90..27ac4dc 100644
>> --- a/gcc/config/arm/arm.h
>> +++ b/gcc/config/arm/arm.h
>> @@ -288,6 +288,9 @@ extern void
>> (*arm_lang_output_object_attributes_hook)(void);
>> #define TARGET_BPABI false
>> #endif
>>
>> +#define ENDIAN_LANE_N(mode, n) \
>> + (BYTES_BIG_ENDIAN ? GET_MODE_NUNITS (mode) - 1 - n : n)
>> +
>
>
> Given we are making changes here to how this all works on bigendian, have
> you tested armeb at all?
I tested on big endian, and it passes, except for a testsuite issue
with the *_f16 tests, which fail because they are built without the
fp16 options on big endian. This is because
check_effective_target_arm_neon_fp16_ok_nocache gets an ICE when it
attempts to compile the test program. I think those fp16 intrinsics
are in your area, do you want to take a look? :)
Thanks for the review
Charles
next prev parent reply other threads:[~2015-10-14 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 0:00 [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages charles.baylis
2015-10-07 0:00 ` [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins charles.baylis
2015-10-12 10:58 ` Alan Lawrence
2015-10-14 22:02 ` Charles Baylis [this message]
2015-10-19 16:59 ` Alan Lawrence
2015-10-07 0:00 ` [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier charles.baylis
2015-10-12 10:50 ` Alan Lawrence
2015-10-07 0:01 ` [PATCH 3/3] [ARM] PR63870 Enable test cases charles.baylis
2015-10-09 14:04 ` [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages Charles Baylis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnVucCrVZDr3xrag-GYdURLHLFrYnz_PKnP8QFZP7=-a-wYLg@mail.gmail.com' \
--to=charles.baylis@linaro.org \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).